chore: fixed test cases related to Internal Transfer #37659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohitwaghchaure
requested review from
s-aga-r,
deepeshgarg007 and
ruthra-kumar
as code owners
rohitwaghchaure
added
the
backport develop
mergify bot
pushed a commit
that referenced
this pull request
Oct 24, 2023
(cherry picked from commit 72d32a4) # Conflicts: # erpnext/accounts/doctype/sales_invoice/test_sales_invoice.py # erpnext/stock/doctype/purchase_receipt/test_purchase_receipt.py
rohitwaghchaure
added a commit
that referenced
this pull request
Oct 25, 2023
* fix(delivery): rename dt fetch stop action (backport #37605) (#37606) fix(delivery): rename dt fetch stop action (cherry picked from commit 79d51a0) Co-authored-by: David Arnold <[email protected]> * fix: incorrect cost center in the purchase invoice (backport #37591) (#37609) * fix: incorrect cost center in the purchase invoice (#37591) (cherry picked from commit 14b009b) # Conflicts: # erpnext/accounts/doctype/purchase_invoice/test_purchase_invoice.py * chore: fix conflicts --------- Co-authored-by: rohitwaghchaure <[email protected]> * fix(minor): filter bank accounts in bank statement import (#37525) fix(minor): filter bank accounts in bank statement import (#37525) fix: filter by company in bank account (cherry picked from commit 9d39297) Co-authored-by: Gursheen Kaur Anand <[email protected]> * fix: set empty value for tax template in item details (#37496) * fix: set empty value for tax template in item details (#37496) * fix: empty tax template for items with invalid templates * fix: test for empty tax template * fix: test for item tax template calculation * fix: test for pos inv tax template calculation (cherry picked from commit b0d440c) # Conflicts: # erpnext/accounts/doctype/pos_invoice/test_pos_invoice.py * chore: resolve conflicts --------- Co-authored-by: Gursheen Kaur Anand <[email protected]> * fix(minor): filter tax template based on company in subscription (#37562) fix: filter tax template based on company (cherry picked from commit 1a2f659) Co-authored-by: Gursheen Anand <[email protected]> * fix: Cash flow mapping fix (#37522) Cash flow mapping fix * fix: remove from or target warehouse for non internal transfer entries (backport #37612) (#37628) fix: remove from or target warehouse for non internal transfer entries (#37612) (cherry picked from commit 5136fe1) Co-authored-by: rohitwaghchaure <[email protected]> * Revert "fix: set empty value for tax template in item details (#37496)" Revert "fix: set empty value for tax template in item details (#37496)" This reverts commit ec208b8. * refactor: gain_loss posting date fields in the allocation table (cherry picked from commit 55dbcee) * refactor: introduce fields in popup (cherry picked from commit 5323bb7) * refactor: pass gain loss posting date to controller (cherry picked from commit 7e600a6) * test: varying posting date for gain loss journal (cherry picked from commit 514d543) * fix: overallocation on Payment with PO/SO (cherry picked from commit 23df420) # Conflicts: # erpnext/accounts/utils.py * test: overalloction on reconciliation when PO is involved (cherry picked from commit 946228d) * refactor(test): make use of utility methods (cherry picked from commit 547993f) * chore: fix flakiness `test_sales_order_partial_advance_payment` (cherry picked from commit 4dff2c7) * chore: resolve conflict * fix: close employee loan on write off (#37638) * fix: exclude written off amount while calculating loan repayment * fix: revert exclude written off amount while calculating loan repayment * fix: close employee loan on write off * refactor: button on PE to filter associated Journals (cherry picked from commit 150728d) # Conflicts: # erpnext/accounts/doctype/payment_entry/payment_entry.js * chore: resolve conflict * fix: incorrect process loss validation for multiple finished items (backport #37576) (#37656) fix: incorrect process loss validation for multiple finished items (#37576) (cherry picked from commit 92cbe58) Co-authored-by: rohitwaghchaure <[email protected]> * chore: fixed test cases related to Internal Transfer (#37659) * fix: GL Entries for receiving non CWIP assets using Purchase Receipt (#37660) * fix: GL Entries for receiving non CWIP assets using Purchase Receipt * fix: rearrange functions * chore: rearrange functions * chore: rearrange functions * fix: Purchase Invoice GL entires for assets * test: cwip accounting unit tests * chore: Attribute error * chore: Purchase Invoice tests * chore: Missing asset account * chore: Missing asset account * chore: update tests * fix: Internal transfer GL Entries * test: Deprecate tests * test: Depricate tests * test: Depricate tests * chore: make `Reserve Stock` checkbox visible in SO * refactor: rename field `Auto Reserve Stock for Sales Order` * feat: add fields to hold SO and SO Item ref in PR Item * test: Deprecate tests * test: Depricate tests * test: Depricate tests * refactor: Remove expense included in valuation accounts * chore: Add back default in transit warehousefield --------- Co-authored-by: s-aga-r <[email protected]> * fix: wrong german translation (#37658) --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: David Arnold <[email protected]> Co-authored-by: rohitwaghchaure <[email protected]> Co-authored-by: Gursheen Kaur Anand <[email protected]> Co-authored-by: Gursheen Anand <[email protected]> Co-authored-by: saeedkola <[email protected]> Co-authored-by: Deepesh Garg <[email protected]> Co-authored-by: ruthra kumar <[email protected]> Co-authored-by: Anand Baburajan <[email protected]> Co-authored-by: s-aga-r <[email protected]> Co-authored-by: Raffael Meyer <[email protected]>
rohitwaghchaure
added a commit
that referenced
this pull request
Oct 25, 2023
#37662) * chore: fixed test cases related to Internal Transfer (#37659) (cherry picked from commit 72d32a4) # Conflicts: # erpnext/accounts/doctype/sales_invoice/test_sales_invoice.py # erpnext/stock/doctype/purchase_receipt/test_purchase_receipt.py * chore: fix conflicts * chore: fix conflicts * chore: fix test cases --------- Co-authored-by: rohitwaghchaure <[email protected]>
mergify bot
added a commit
that referenced
this pull request
Oct 25, 2023
#37662) * chore: fixed test cases related to Internal Transfer (#37659) (cherry picked from commit 72d32a4) # Conflicts: # erpnext/accounts/doctype/sales_invoice/test_sales_invoice.py # erpnext/stock/doctype/purchase_receipt/test_purchase_receipt.py * chore: fix conflicts * chore: fix conflicts * chore: fix test cases --------- Co-authored-by: rohitwaghchaure <[email protected]> (cherry picked from commit 886102d) # Conflicts: # erpnext/accounts/doctype/sales_invoice/test_sales_invoice.py # erpnext/stock/doctype/purchase_receipt/test_purchase_receipt.py
rohitwaghchaure
added
backport version-14-hotfix
mergify bot
pushed a commit
that referenced
this pull request
Oct 28, 2023
(cherry picked from commit 72d32a4)
rohitwaghchaure
added a commit
that referenced
this pull request
Oct 28, 2023
#37733) * chore: fixed test cases related to Internal Transfer (#37659) (cherry picked from commit 72d32a4) * chore: fix test cases --------- Co-authored-by: rohitwaghchaure <[email protected]>
|
🎉 This PR is included in version 14.46.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed below test cases