Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use gzip library's compress() and decompress() methods directly #37611

Merged
merged 1 commit into from
Oct 21, 2023

Conversation

akhilnarang
Copy link
Member

The util methods in framework were added for python2.7 compat, so can be removed

…ctly

The util methods in framework were added for python2.7 compat, so can be removed

Signed-off-by: Akhil Narang <[email protected]>
@github-actions github-actions bot added needs-tests This PR needs automated unit-tests. stock labels Oct 20, 2023
@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Merging #37611 (7e11756) into develop (38ca164) will increase coverage by 0.48%.
Report is 108 commits behind head on develop.
The diff coverage is 77.57%.

@@             Coverage Diff             @@
##           develop   #37611      +/-   ##
===========================================
+ Coverage    66.86%   67.35%   +0.48%     
===========================================
  Files          791      757      -34     
  Lines        62519    60124    -2395     
===========================================
- Hits         41805    40497    -1308     
+ Misses       20714    19627    -1087     
Files Coverage Δ
...account_closing_balance/account_closing_balance.py 97.91% <100.00%> (+4.29%) ⬆️
...xt/accounts/doctype/payment_entry/payment_entry.py 83.77% <100.00%> (+0.08%) ⬆️
...ounts/doctype/purchase_invoice/purchase_invoice.py 83.97% <100.00%> (+0.02%) ⬆️
...xt/accounts/doctype/sales_invoice/sales_invoice.py 83.88% <100.00%> (-0.08%) ⬇️
...nts/doctype/subscription_plan/subscription_plan.py 40.47% <ø> (ø)
erpnext/accounts/doctype/tax_rule/tax_rule.py 93.10% <100.00%> (+1.36%) ⬆️
.../report/accounts_receivable/accounts_receivable.py 90.56% <100.00%> (ø)
...omparison/general_and_payment_ledger_comparison.py 100.00% <100.00%> (ø)
erpnext/controllers/selling_controller.py 80.75% <100.00%> (ø)
erpnext/erpnext_integrations/utils.py 0.00% <ø> (-42.23%) ⬇️
... and 35 more

... and 13 files with indirect coverage changes

@ankush ankush merged commit 21c3d9c into frappe:develop Oct 21, 2023
mergify bot pushed a commit that referenced this pull request Oct 21, 2023
…ctly (#37611)

The util methods in framework were added for python2.7 compat, so can be removed

Signed-off-by: Akhil Narang <[email protected]>

[skip ci]

(cherry picked from commit 21c3d9c)
ankush pushed a commit that referenced this pull request Oct 21, 2023
…ctly (backport #37611) (#37621)

refactor: use gzip library's compress() and decompress() methods directly (#37611)

The util methods in framework were added for python2.7 compat, so can be removed

Signed-off-by: Akhil Narang <[email protected]>

[skip ci]

(cherry picked from commit 21c3d9c)

Co-authored-by: Akhil Narang <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-15-hotfix needs-tests This PR needs automated unit-tests. stock
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants