Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add regional support to extend purchase gl entries #37595

Merged
merged 2 commits into from
Oct 20, 2023
Merged

fix: add regional support to extend purchase gl entries #37595

merged 2 commits into from
Oct 20, 2023

Conversation

vorasmit
Copy link
Collaborator

@vorasmit vorasmit commented Oct 19, 2023 •
edited
Loading

Changes Made

  • Regional overrides to update GL Entry in Purchase Receipt and Stock Controller
  • Fallback for cost-center for fixed assets for consistency
  • Introduced doc hooks before_gl_preview and before_sl_preview
  • Filters as frappe._dict to avoid errors where dot notation was used in the report
  • Removed load_from_db for Purchase receipt as it was no longer required

image_2023-10-19_19-01-23

Additional Fix

Earlier existing doc was updated from update_billed_amount_based_on_po using set_value requiring load_from_db. Now trying to update the existing doc with db_set.

@vorasmit vorasmit mentioned this pull request Oct 19, 2023
Merged
14 tasks
@github-actions github-actions bot added needs-tests This PR needs automated unit-tests. stock labels Oct 19, 2023
@vorasmit vorasmit marked this pull request as ready for review October 19, 2023 17:11
@deepeshgarg007 deepeshgarg007 merged commit 2a7d1c4 into frappe:develop Oct 20, 2023
1 check passed
@vorasmit vorasmit deleted the purchase-gl branch October 20, 2023 11:53
@deepeshgarg007 deepeshgarg007 added the backport version-14-hotfix backport to version 14 label Oct 25, 2023
@mergify mergify bot mentioned this pull request Oct 25, 2023
Merged
deepeshgarg007 added a commit that referenced this pull request Oct 25, 2023
@deepeshgarg007
Merge pull request #37687 from frappe/mergify/bp/version-14-hotfix/pr…
a615535 
…-37595

fix: add regional support to extend purchase gl entries (#37595)
deepeshgarg007 added a commit that referenced this pull request Oct 26, 2023
@deepeshgarg007
Merge pull request #37699 from frappe/mergify/bp/version-14/pr-37687
f5120a6 
fix: add regional support to extend purchase gl entries (#37595)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deepeshgarg007 deepeshgarg007 Awaiting requested review from deepeshgarg007

@rohitwaghchaure rohitwaghchaure Awaiting requested review from rohitwaghchaure rohitwaghchaure is a code owner

@s-aga-r s-aga-r Awaiting requested review from s-aga-r

@ruthra-kumar ruthra-kumar Awaiting requested review from ruthra-kumar ruthra-kumar is a code owner

Assignees
No one assigned
Labels
backport version-14-hotfix backport to version 14 needs-tests This PR needs automated unit-tests. stock
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vorasmit @deepeshgarg007