Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gov compliance for tax withholding report #37590

Conversation

GursheenK
Copy link
Member

Changes

  • Avoid relying only on against field for fetching invoice GL entries until bug for correctly renaming against field is fixed.
  • Change the column order of the Tax Withholding Report for better Govt Compliance.
  • Show the TDS details grouped by Section code.
  • Add Proprietorship and Partnership options in Supplier and Customer types.

Closes #37186

no-docs

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Oct 19, 2023
@deepeshgarg007 deepeshgarg007 merged commit fc41995 into frappe:develop Nov 1, 2023
9 of 11 checks passed
deepeshgarg007 added a commit that referenced this pull request Nov 1, 2023
…-37590

fix: gov compliance for tax withholding report (#37590)
deepeshgarg007 pushed a commit that referenced this pull request Nov 2, 2023
* refactor: avoid relying only on against in tds docs query

(cherry picked from commit 705dada)

* chore: change column order

(cherry picked from commit 7ecc0d5)

* fix: sort by section code

(cherry picked from commit 4471ad5)

* feat: proprietorship & partnership options in entity type

(cherry picked from commit ed2457b)

# Conflicts:
#	erpnext/buying/doctype/supplier/supplier.json
#	erpnext/selling/doctype/customer/customer.json

* chore: linting issues

(cherry picked from commit 7544101)

* feat: add cols for supplier inv details

(cherry picked from commit 6d5ccde)

* chore: resolve conflicts

* chore: resolve conflicts

* chore: linting issues

---------

Co-authored-by: Gursheen Anand <[email protected]>
Co-authored-by: Gursheen Kaur Anand <[email protected]>
frappe-pr-bot pushed a commit that referenced this pull request Nov 8, 2023
# [14.47.0](v14.46.7...v14.47.0) (2023-11-08)

### Bug Fixes

* `TypeError` in PR for non-stock item ([ef4471f](ef4471f))
* add missing disbursement account in update_old_loans patch ([ad64065](ad64065))
* add translation wrapper (backport [#37911](#37911)) ([#37946](#37946)) ([c53d281](c53d281))
* don't reset rate if greater than zero in standalone debit note (backport [#37935](#37935)) ([#37940](#37940)) ([64658fc](64658fc))
* fetch asset received but not billed account only when needed ([7df4009](7df4009))
* gov compliance for tax withholding report ([#37590](#37590)) ([273cc35](273cc35))
* In-Transit Warehouse company filter (backport [#37796](#37796)) ([#37797](#37797)) ([0b1da08](0b1da08))
* link between parent and child procedure (backport [#37903](#37903)) ([#37943](#37943)) ([24da29a](24da29a))
* list index out of range ([#37880](#37880)) ([05fed9e](05fed9e))
* make `Material Request Item` required if `Material Request` is set in PO (backport [#37928](#37928)) ([#37936](#37936)) ([c870120](c870120))
* permission error while creating Supplier Quotation from Portal (backport [#37864](#37864)) ([#37870](#37870)) ([1a3dae0](1a3dae0))
* **plaid:** Do not sync pending transactions ([ffdc11b](ffdc11b))
* POS change amount gl entry with no amount ([#37799](#37799)) ([5e1a89b](5e1a89b))
* Quality Inspection Parameter migration - DuplicateEntryError due to case sensitivity (backport [#37499](#37499)) ([#37916](#37916)) ([eb3630b](eb3630b))
* remove voucher type and no for Item and Warehouse based reposting (backport [#37849](#37849)) ([#37850](#37850)) ([e19cade](e19cade))
* standard submit perm in repost ledger for editable invoices (backport [#37826](#37826)) ([#37854](#37854)) ([69b569d](69b569d))
* status for over delivery or billing ([d8e7430](d8e7430))
* type error on new payment entry ([38184f7](38184f7))
* typo in AR report ([3d72ec7](3d72ec7))
* validate so item with qtn ([4a225b0](4a225b0))

### Features

* reserved production plan sub assembly items (backport [#37884](#37884)) ([#37926](#37926)) ([4de97a4](4de97a4))
* settings page for repost ([09cde5d](09cde5d))
* **Stock Balance:** add filters from route (backport [#37836](#37836)) ([#37839](#37839)) ([e8a706a](e8a706a))

### Performance Improvements

* Add index to supplier invoice field (backport [#37861](#37861)) ([#37862](#37862)) ([2c93f81](2c93f81))
* index return against for purchase invoice (backport [#37881](#37881)) ([#37882](#37882)) ([fed25fa](fed25fa))
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-14-hotfix backport to version 14 backport version-15-hotfix needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need change in TDS Payable Monthly report as per Gov. compliance
2 participants