Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(customer): quick form and integration fixes #37386

Merged
merged 3 commits into from
Nov 11, 2023
Merged

fix(customer): quick form and integration fixes #37386

merged 3 commits into from
Nov 11, 2023

Conversation

blaggacao
Copy link
Collaborator

@blaggacao blaggacao commented Oct 6, 2023 •
edited
Loading

Context

Consider three scenarios:

  1. When customer is created via quick entry, the name of the contact should follow the name of the customer. Clarification: this is the case where the system is configured for automatic contact creation, presumably a high volume B2C business seeking the agility of a unified creation vs a more elaborate relationship between customers and contacts / addresses.

  2. When customer is created via quick entry, and an address is created, it should be the default billing and shipping address

  3. When customer is create from a webhook via an integration and permission on the customer are bypassed, then this intent should continue to be honored during address and contact creation

Proposed Solution

  1. Change techincal name to human readable customer_name
  2. Set default shipping and billing address (as even intended, but not implemented by the original code author 6 years ago)
  3. Replay eventual flags, if present

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Oct 6, 2023
@bosue

This comment was marked as off-topic.

Sign in to view
@blaggacao

This comment was marked as resolved.

Sign in to view
@bosue

This comment was marked as resolved.

Sign in to view
@blaggacao
Copy link
Collaborator Author

should be backported to v15

@codecov
Copy link

codecov bot commented Oct 26, 2023 •
edited
Loading

Codecov Report

Merging #37386 (c31f33f) into develop (7a3e4a8) will decrease coverage by 0.01%.
Report is 22 commits behind head on develop.
The diff coverage is 65.71%.

@@             Coverage Diff             @@
##           develop   #37386      +/-   ##
===========================================
- Coverage    67.33%   67.32%   -0.01%     
===========================================
  Files          757      757              
  Lines        60147    60170      +23     
===========================================
+ Hits         40497    40510      +13     
- Misses       19650    19660      +10
Files Coverage Δ
erpnext/controllers/status_updater.py 88.42% <ø> (ø)
erpnext/selling/doctype/sales_order/sales_order.py 79.12% <ø> (ø)
...doctype/landed_cost_voucher/landed_cost_voucher.py 87.59% <ø> (ø)
erpnext/selling/doctype/customer/customer.py 74.91% <42.85%> (-0.91%) ⬇️
...tax_withholding_details/tax_withholding_details.py 79.87% <71.42%> (+0.42%) ⬆️

... and 3 files with indirect coverage changes

@deepeshgarg007 deepeshgarg007 merged commit ae50814 into frappe:develop Nov 11, 2023
13 checks passed
mergify bot pushed a commit that referenced this pull request Nov 11, 2023
@blaggacao @mergify
fix(customer): quick form and integration fixes (#37386)
b47a043 
(cherry picked from commit ae50814)
@mergify mergify bot mentioned this pull request Nov 11, 2023
Merged
deepeshgarg007 pushed a commit that referenced this pull request Nov 11, 2023
@mergify @blaggacao
fix(customer): quick form and integration fixes (#37386)
02e2258 
fix(customer): quick form and integration fixes (#37386)

(cherry picked from commit ae50814)

Co-authored-by: David Arnold <[email protected]>
@blaggacao blaggacao deleted the fix/customer-quick-form-and-integration-flow branch November 11, 2023 15:00
@barredterra
Copy link
Collaborator

Mapping customer name to first name is a bit better, but still often incorrect, especially when the customer is a company. Contact has a dedicated field for the company name.

@blaggacao blaggacao mentioned this pull request Nov 12, 2023
Merged
frappe-pr-bot pushed a commit that referenced this pull request Nov 16, 2023
@frappe-bot
chore(release): Bumped to Version 15.1.0
54a6fba 
# [15.1.0](v15.0.0...v15.1.0) (2023-11-16)

### Bug Fixes

* `PermissionError` while creating DN from SO (backport [#37758](#37758)) ([#37768](#37768)) ([e742310](e742310))
* `TypeError` in PR for non-stock item (backport [#37819](#37819)) ([#37842](#37842)) ([847dd9e](847dd9e))
* add translation wrapper (backport [#37911](#37911)) ([#37947](#37947)) ([915ca47](915ca47))
* asset depreciation ledger (backport [#37991](#37991)) ([#37993](#37993)) ([b3562bd](b3562bd))
* avoid name clash in delivery stop (backport [#37306](#37306)) ([#37702](#37702)) ([bfd240a](bfd240a))
* close `Credit Limit Crossed` dialog (backport [#38052](#38052)) ([#38059](#38059)) ([cff56d4](cff56d4))
* COA Importer app related issues ([#37238](#37238)) ([d5bf7a0](d5bf7a0))
* consider reserved stock while cancelling a stock transaction (backport [#37754](#37754)) ([#37906](#37906)) ([e0b0b6b](e0b0b6b))
* credit note receive payment entry ([9781f9b](9781f9b))
* **customer:** contact creation for companies ([#38055](#38055)) ([fc09d75](fc09d75))
* **customer:** quick form and integration fixes ([#37386](#37386)) ([02e2258](02e2258))
* **defaults:** apply discount and provisonal defaults from item group and brand if available (backport [#37466](#37466)) ([#37704](#37704)) ([f382b1c](f382b1c))
* deprecate unused create_contact ([6f2b34e](6f2b34e))
* don't reset rate if greater than zero in standalone debit note (backport [#37935](#37935)) ([#37941](#37941)) ([e156564](e156564))
* force delete removed report (backport [#37668](#37668)) ([#37670](#37670)) ([a871d95](a871d95))
* handle gle for standalone credit and debit notes ([6e463b1](6e463b1))
* Identical items are added line by line instead of grouped together in POS ([#37986](#37986)) ([011cf3d](011cf3d))
* ignore Stock Reservation for future dated PR (backport [#37979](#37979)) ([#37990](#37990)) ([d74f0ef](d74f0ef))
* In-Transit Warehouse company filter (backport [#37796](#37796)) ([#37798](#37798)) ([254ec2c](254ec2c))
* incorrect material request quantity in production plan (backport [#37785](#37785)) ([#37790](#37790)) ([8b3c4a9](8b3c4a9))
* indentation issue in the Production Plan Summary report (backport [#38019](#38019)) ([#38069](#38069)) ([6d325a4](6d325a4))
* indexing on Delivery Note Item (backport [#37766](#37766)) ([#37778](#37778)) ([98a7c17](98a7c17))
* link between parent and child procedure (backport [#37903](#37903)) ([#37944](#37944)) ([a065f22](a065f22))
* list index out of range (backport [#37890](#37890)) ([#37920](#37920)) ([e71ef10](e71ef10))
* make `Material Request Item` required if `Material Request` is set in PO (backport [#37928](#37928)) ([#37937](#37937)) ([7ad0817](7ad0817))
* make adjustment entry using stock reconciliation (backport [#37995](#37995)) ([#38009](#38009)) ([b23fa1f](b23fa1f))
* make changes that enable gantt view for job cards (backport [#37661](#37661)) ([#37757](#37757)) ([f132552](f132552))
* make item field read-only in batch (backport [#38010](#38010)) ([#38034](#38034)) ([99b7cdb](99b7cdb))
* make project page translatable (backport [#37743](#37743)) ([#37801](#37801)) ([59e67cd](59e67cd))
* Mark Status field in Payment Entry 'no_copy'. ([#38000](#38000)) ([3c0f8b1](3c0f8b1))
* minor change added to test_case ([b1714ec](b1714ec))
* minor issue ([24be044](24be044))
* **minor:** set tax values for item variants (backport [#37674](#37674)) ([#37739](#37739)) ([5c46d74](5c46d74))
* new logic for handling revaluation journals ([fb71a6e](fb71a6e))
* Not able to save subcontracting receipt ([#38085](#38085)) ([a874997](a874997))
* **packed_item:** ensure proper names for ref integrity (backport [#37597](#37597)) ([#37794](#37794)) ([9aa29f5](9aa29f5))
* permission error while creating Supplier Quotation from Portal (backport [#37864](#37864)) ([#37871](#37871)) ([be8399f](be8399f))
* **plaid:** Do not sync pending transactions ([2149de4](2149de4))
* POS change amount gl entry with no amount ([#37799](#37799)) ([fd7a768](fd7a768))
* Quality Inspection Parameter migration - DuplicateEntryError due to case sensitivity (backport [#37499](#37499)) ([#37917](#37917)) ([7d0f1f4](7d0f1f4))
* remove from or target warehouse for non internal transfer entries (backport [#37612](#37612)) ([#37627](#37627)) ([3155790](3155790))
* remove validation for negative outstanding invoices ([8602a3e](8602a3e))
* remove voucher type and no for Item and Warehouse based reposting ([b96be67](b96be67))
* sales order not assigned to territory orders (backport [#37905](#37905)) ([#38025](#38025)) ([40cc3a7](40cc3a7))
* skip check for removed validation ([22e58e0](22e58e0))
* sort by section code ([06bb1a3](06bb1a3))
* standard submit perm in repost ledger for editable invoices (backport [#37826](#37826)) ([#37855](#37855)) ([71361f7](71361f7))
* status for over delivery or billing ([95d6742](95d6742))
* test for invoice returns ([a89af58](a89af58))
* type error on new payment entry ([5937135](5937135))
* typo in AR report ([fc3d303](fc3d303))
* typo in function name and msg (backport [#37722](#37722)) ([#37741](#37741)) ([4819fde](4819fde))
* unsupported operand type(s) for serial and batch bundle in POS Invoice (backport [#37721](#37721)) ([#37731](#37731)) ([b03c65f](b03c65f))
* use get_all instead of get_list ([2a5b3bd](2a5b3bd))
* validate so item with qtn ([71538cf](71538cf))
* valuation rate for the subcontracting receipt supplied items with Serial and Batch Bundle (backport [#38094](#38094)) (backport [#38097](#38097)) ([#38101](#38101)) ([880cea5](880cea5))

### Features

* **accounts_receivable:** test_case added for multi-select customer group ([848efe8](848efe8))
* add cols for supplier inv details ([e51e5b3](e51e5b3))
* allow return of components for SCO that don't have SCR created (backport [#37686](#37686)) ([#37693](#37693)) ([4044325](4044325))
* auto reserve stock for Sales Order on purchase (backport [#37603](#37603)) ([#37648](#37648)) ([da5bf50](da5bf50))
* **delivery:** link to delivery notes list view from delivery trip (backport [#37604](#37604)) ([#37696](#37696)) ([08ea62f](08ea62f))
* multi-select customer group in AR Report ([fff294f](fff294f))
* proprietorship & partnership options in entity type ([6df125a](6df125a))
* reserved production plan sub assembly items (backport [#37884](#37884)) ([#37927](#37927)) ([df90fd7](df90fd7))
* settings page for repost ([c047fd7](c047fd7))
* **Stock Balance:** add filters from route (backport [#37836](#37836)) ([#37840](#37840)) ([fad8228](fad8228))

### Performance Improvements

* Add index to supplier invoice field (backport [#37861](#37861)) ([#37863](#37863)) ([b1982a6](b1982a6))
* index return against for purchase invoice (backport [#37881](#37881)) ([#37883](#37883)) ([febd20a](febd20a))
@barredterra barredterra mentioned this pull request Dec 14, 2023
Merged
barredterra pushed a commit to barredterra/erpnext that referenced this pull request Dec 14, 2023
@blaggacao @barredterra
fix(customer): quick form and integration fixes (frappe#37386)
6ed7c66
deepeshgarg007 added a commit that referenced this pull request Dec 15, 2023
@deepeshgarg007
Merge pull request #38753 from barredterra/contact-from-customer-crea…
e539152 
…tion

fix: address and contact from customer creation (backport #38055, #37386, #38060)
frappe-pr-bot pushed a commit that referenced this pull request Dec 20, 2023
@frappe-bot
chore(release): Bumped to Version 14.55.0
8657ba3 
# [14.55.0](v14.54.2...v14.55.0) (2023-12-20)

### Bug Fixes

* close PO on SCO close (backport [#38667](#38667)) ([#38680](#38680)) ([22b442d](22b442d))
* **customer:** contact creation for companies ([#38055](#38055)) ([ed9b38b](ed9b38b))
* **customer:** quick form and integration fixes ([#37386](#37386)) ([6ed7c66](6ed7c66))
* error while filtering on name on reconciliation tool ([30b6321](30b6321))
* fetch exc rate of multi currency journals ([bf585de](bf585de))
* fetch item_tax_template values if fields with fetch_from exisit ([24ae45c](24ae45c))
* get customers for leaderboard ([9dfe342](9dfe342))
* get items for leaderboard ([812b301](812b301))
* get sales partner for leaderboard ([c63f873](c63f873))
* get sales person for leaderboard ([df93447](df93447))
* get suppliers for leaderboard ([7477ff3](7477ff3))
* if not budget then don't validate ([#38861](#38861)) ([d375164](d375164))
* incoming rate for sales return with Moving Average valuation method ([#38849](#38849)) ([7fdac62](7fdac62))
* incorrect limit ([#38818](#38818)) ([e18dc5c](e18dc5c))
* Init internal child table values ([d593f81](d593f81))
* item variant with manufacturer ([#38845](#38845)) ([e0c8ff1](e0c8ff1))
* not able to cancel SCR with Batch ([#38817](#38817)) ([fb5090f](fb5090f))
* not able to make inter-company po from so ([#38826](#38826)) ([23042df](23042df))
* on closed unreserved the production plan qty ([#38848](#38848)) ([2184e8e](2184e8e))
* Reset SLA on issue doesn't work (backport [#38789](#38789)) ([#38790](#38790)) ([942f34a](942f34a))
* supplier removed on selection of item (backport [#38712](#38712)) ([#38732](#38732)) ([dda95ea](dda95ea))
* timezone aware SLA banner (backport [#38745](#38745)) ([#38746](#38746)) ([73d525e](73d525e))
* **ux:** don't override Item Name and Description in MR (backport [#38720](#38720)) ([#38762](#38762)) ([f7bfbd8](f7bfbd8))
* validation error on reconciling PE to Journals as Invoice ([9836205](9836205))
* wrong currency in Stock Balance report (backport [#38778](#38778)) ([#38779](#38779)) ([e05b23c](e05b23c))
* wrong paid and cn amount on pos invoice ([77da0da](77da0da))

### Features

* **RFQ:** special properties in print preview (backport [#38725](#38725)) ([#38726](#38726)) ([2290750](2290750))
* set lead name from email ([1469ca7](1469ca7))

### Performance Improvements

* index `return_against` on delivery note (backport [#38827](#38827)) ([#38831](#38831)) ([4114760](4114760))
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deepeshgarg007 deepeshgarg007 deepeshgarg007 approved these changes

@ruthra-kumar ruthra-kumar Awaiting requested review from ruthra-kumar ruthra-kumar is a code owner

Assignees
No one assigned
Labels
backport version-15-hotfix needs-tests This PR needs automated unit-tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@blaggacao @bosue @barredterra @deepeshgarg007