build: update shopify SDK #274
Conversation
ankush
commented
Oct 24, 2023
ankush
commented
- build: update shopify sdk
- fix: product sync
- fix: Correctly wrap function
Without this function signature is not passed along and causes frappe's introspection magic to fail
|
|
||
| const { message: jobs } = await frappe.db.get_list("RQ Job", {filters: {"status": ("in", ("queued", "started"))}}); | ||
|
|
||
| const jobs = await frappe.db.get_list("RQ Job", {filters: {"status": ("in", ("queued", "started"))}}); |
There was a problem hiding this comment.
Is there any way we can run version-specific code from js? Because, this doesn't work in version-13 as it doesn't have RQ Jobs.
There was a problem hiding this comment.
We can check version from frappe.boot.versions (I don't remember actual key, but it should be there)
There was a problem hiding this comment.
Yes. Got it.
parseInt(frappe.boot.versions.frappe); // returns 13, 14, or 15Which is better? Calling separate functions based on the frappe version or having separate branches of this repo like version-13 and version-15?
Or is version-13 outdated enough to warrant an upgrade?
There was a problem hiding this comment.
V13 will be EOL in 2 months. Maintaining multiple branches is kind of a hassle.
There was a problem hiding this comment.
Diff code based on condition is fine.
There was a problem hiding this comment.
Understood. But again, we only have one customer on v13 using this. I'm not sure if there are any others still on v13 with this app.
I could just fork this and keep the old code on it instead of changing the upstream for one single customer.
It will also prevent any future updates messing with v13.
|
🎉 This PR is included in version 1.19.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
