fix: misc fixes #191
Merged
fix: misc fixes #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ankush
commented
Jun 27, 2022
ankush
commented
- support configuring log settings for e-commerce integration logs (v14 only) refactor!: improve/extend log settings frappe#17159
- show log button on shopify setting page
- better handle SO sync for unicommerce when using in "completed orders" mode
- dont log error when querying for item's existence
Use case: 1. If order is created long time ago but completed in last 1 day then it should still show up in the searched list. This is only applicable to users using "only sync completed orders"
For all new item, this is only done to check if they don't already exist. Logging them as error not required.
|
🎉 This PR is included in version 1.11.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.