Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(amazon-sp): validate credentials on save #176

Merged
merged 2 commits into from
Mar 2, 2022

Conversation

s-aga-r
Copy link
Contributor

@s-aga-r s-aga-r commented Feb 28, 2022

Validate credentials on save with Amazon. In case of any wrong credential(s), an error will be thrown with a description.

Example:
Screenshot 2022-02-28 at 11 08 56 PM

@s-aga-r s-aga-r requested a review from ankush as a code owner February 28, 2022 17:39
@s-aga-r s-aga-r force-pushed the amazon/validate-on-save branch from 3119501 to 3257794 Compare February 28, 2022 17:50
@codecov
Copy link

codecov bot commented Feb 28, 2022

Codecov Report

Merging #176 (0e02721) into develop (f8ac70b) will increase coverage by 0.27%.
The diff coverage is 38.09%.

@@             Coverage Diff             @@
##           develop     #176      +/-   ##
===========================================
+ Coverage    40.93%   41.20%   +0.27%     
===========================================
  Files           62       62              
  Lines         4124     4138      +14     
===========================================
+ Hits          1688     1705      +17     
+ Misses        2436     2433       -3     
Impacted Files Coverage Δ
...on/doctype/amazon_sp_api_settings/amazon_sp_api.py 60.98% <0.00%> (+4.00%) ⬆️
...e/amazon_sp_api_settings/amazon_sp_api_settings.py 36.73% <33.33%> (-0.23%) ⬇️
...octype/amazon_sp_api_settings/amazon_repository.py 64.30% <87.50%> (+0.61%) ⬆️

@s-aga-r s-aga-r merged commit 47d731f into frappe:develop Mar 2, 2022
@s-aga-r s-aga-r deleted the amazon/validate-on-save branch March 8, 2022 06:52
@s-aga-r s-aga-r added the bug Something isn't working label Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants