Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ERR cannot parse identity line: unknown identity format: # OpenSSH authorized_keys file format is described in sshd(8) manual page. #50

Closed
vt-alt opened this issue Dec 17, 2023 · 2 comments · Fixed by #72
Closed

ERR cannot parse identity line: unknown identity format: # OpenSSH authorized_keys file format is described in sshd(8) manual page. #50

vt-alt opened this issue Dec 17, 2023 · 2 comments · Fixed by #72
Labels
bug Something isn't working

Comments

@vt-alt
Copy link

vt-alt commented Dec 17, 2023 •
edited
Loading

Comments in authorized_keys cause an error: ERR cannot parse identity line: unknown identity format: # OpenSSH authorized_keys file format is described in sshd(8) manual page.

ALT Linux have comment in authorized_keys at the 1st line for each user by default:

# OpenSSH authorized_keys file format is described in sshd(8) manual page.

ps. Alto it's common for users to comment old keys instead of deleting them so this is not an error.
@francoismichel
Copy link
Owner

francoismichel commented Dec 17, 2023 •
edited
Loading

I am using the ssh_config package to parse the config and I am surprised it does not handle that case. Maybe there is a bad edge case with comments in the first line.
I'll have a look and do a quick fix if the problem comes from github.com/kevinburke/ssh_config.

EDIT: seems I misread and the issue was about authorized_identities and not the SSH config.

@francoismichel francoismichel added the bug Something isn't working label Dec 17, 2023
@francoismichel francoismichel mentioned this issue Dec 18, 2023
Merged
francoismichel added a commit that referenced this issue Dec 18, 2023
@francoismichel
handle commented and empty lines in authorized_indentities (#72)
eb74f88 
Until now, commented lines raised a logging at error level in authorized_indentities and authorized_keys. (#50)
We fixed the logging to explicitly say that empty and commented lines are skipped.
Also added a test case with commented lines in authorized_identities

Fix: #50
@vt-alt
Copy link
Author

vt-alt commented Dec 19, 2023

Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

handle commented and empty lines in authorized_indentities francoismichel/ssh3
2 participants
@francoismichel @vt-alt