feat(docsearch): save content record hit parent in recent searches

francoischalifour · Apr 10, 2020 · 3fe547f · 3fe547f
1 parent 8a02679
commit 3fe547f
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/packages/docsearch-react/src/DocSearch.tsx b/packages/docsearch-react/src/DocSearch.tsx
@@ -83,14 +83,18 @@ export function DocSearch({
   ).current;
 
   const saveRecentSearch = React.useCallback(
-    function saveRecentSearch(item: StoredDocSearchHit) {
+    function saveRecentSearch(item: InternalDocSearchHit) {
+      // We don't store `content` record, but their parent if available.
+      const search = item.type === 'content' ? item.__docsearch_parent : item;
+
       // We save the recent search only if it's not favorited.
       if (
+        search &&
         favoriteSearches
           .getAll()
-          .findIndex(search => search.objectID === item.objectID) === -1
+          .findIndex(x => x.objectID === search.objectID) === -1
       ) {
-        recentSearches.add(item);
+        recentSearches.add(search);
       }
     },
     [favoriteSearches, recentSearches]

diff --git a/packages/docsearch-react/src/stored-searches.ts b/packages/docsearch-react/src/stored-searches.ts
@@ -61,10 +61,6 @@ export function createStoredSearches<TItem extends StoredDocSearchHit>({
         ...hit
       } = (item as unknown) as DocSearchHit;
 
-      if (hit.type === 'content') {
-        return;
-      }
-
       const isQueryAlreadySaved = items.findIndex(
         x => x.objectID === hit.objectID
       );