Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate notifications on WSL without using BurntToast #90

Conversation

eugene-babichenko
Copy link
Contributor

No description provided.

@franciscolourenco
Copy link
Owner

Thank you @eugene-babichenko!
Is there any compatibility issues for existing users?
Would it make sense to still support BurnToast for users who have it installed, but not wslu?

Anyone else on Windows can confirm that this is working?

@eugene-babichenko
Copy link
Contributor Author

@franciscolourenco

Is there any compatibility issues for existing users?

No. We just don't use BurntToast anymore, it do not add any new dependencies or incompatible configuration changes.

Would it make sense to still support BurnToast for users who have it installed, but not wslu?

Hm, I don't understand this question. wslu already was a requirement because it was used to launch powershell scripts.

@meatcar
Copy link

meatcar commented Oct 1, 2020

Tested, works on Ubuntu under WSL2.

As for the wslu dependency, its preinstalled on Fedora Remix, Pengwin, and Ubuntu distros as per wslu README. We only use it after checking if it's available, it isn't a hard dependency currently.

@franciscolourenco franciscolourenco merged commit 56a1d4a into franciscolourenco:master Oct 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants