Use kitty's new o=invisible option in notification protocol #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's a new feature in Kitty 0.31. With that option, the notification is ignored if the window is focused and the tab is active. There's no reliable way to detect Kitty's version, so the user needs to `set -U kitty_notification_unfocused 1`.
|
Closing this pull request. Since Kitty will have its own job notification feature in the upcoming release, now there's no point adding Kitty-specific integration, as a Kitty user probably won't use this plugin. |
|
@jinliu can you share information about this release? Thanks! |
|
The relevant option: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a new feature in Kitty 0.31 (which is just released). With that option, the notification is ignored if the window is focused and the tab is active, so we don't have to detect window state.
There's no reliable way to detect Kitty's version, so the user needs to
set -U kitty_notification_unfocused 1.