Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fish_postexec instead of fish_prompt #130

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

wesalvaro
Copy link
Contributor

Using the fish_postexec event removes the reliance on history as the command that just finished executing is passed in as the first argument to the function. The fish_prompt event is also fired when we don't need to run.

Using the `fish_postexec` event removes the reliance on `history` as the command that just finished executing is passed in as the first argument to the function. The `fish_prompt` event is also fired when we don't need to run.
@franciscolourenco
Copy link
Owner

franciscolourenco commented Sep 25, 2023

fish_postexec was introduced in fish 2.2.0 (released July 12, 2015), so safe to use. Thank you for the PR!

@franciscolourenco franciscolourenco merged commit f332777 into franciscolourenco:master Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants