Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to set the notification expiry #125

Merged

Conversation

huafu
Copy link
Contributor

@huafu huafu commented Nov 9, 2021

Allows to define the notification expiry on linux (when using notify-send).
By default it's set to 0 so the behavior isn't changed.
As added in readme, here is an example:

set -U __done_expire_time 3000 # 3 seconds

@bessey
Copy link

bessey commented Jul 1, 2022

Would love this, really annoying to have to clear your notifications from all the accumulated long running commands this logs

@franciscolourenco
Copy link
Owner

@huafu thank you for the PR! Only now had time to have a look at it, sorry. 2 ideas:

  1. Make the default 3000 (it sounds like a sane default behavior for this application)
  2. Name option _done_notification_duration (a bit more generic) while still explaining in the README that it is currently only working in linux and is ignored by Ubuntu's Notify OSD and GNOME Shell.

What do you think?

@huafu huafu force-pushed the feature/notification-expiry branch from 996ef1e to 227482d Compare October 22, 2023 08:15
@huafu
Copy link
Contributor Author

huafu commented Oct 22, 2023

@franciscolourenco done, except I did NOT list GNOME Shell since it DOES work in Gnome Shell (tested with GNOME Shell 42.9)

Copy link
Owner

@franciscolourenco franciscolourenco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution ❤️

@franciscolourenco franciscolourenco merged commit faadb3f into franciscolourenco:master Oct 22, 2023
@franciscolourenco
Copy link
Owner

Available in https://github.com/franciscolourenco/done/releases/tag/1.18.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants