-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always send a transient notification with notify-send #118
Conversation
I'm sorry I merged the previous PR prematurely. |
IMHO not, but we just wanted to add a backwards compatibility layer in case this broke somebody's workflow. But you can remove it, yes. |
@frazar would you like to remove this check completely in your PR? Thanks! |
Sure! Should be ok now |
Since the default behavior is changing, shouldn't it be mentioned in the docs? |
I will add it at least to the release notes. I wonder if it makes sense to put it in the readme, since transient notifications are the way it was always supposed to work. One concern is wether this option might prevent some users from configuring some notification from remaining in the screen. I would imagine some systems allow users to configure this or not at all? |
I might be misremembering. I just checked and have mine set to never expire in my I think in general the config files for each notification daemon would take precedence so it should be OK |
Fixes #117