Skip to content

Commit

Permalink
fix: correctly parse cli flags (#2196)
Browse files Browse the repository at this point in the history
  • Loading branch information
jirevwe authored Nov 27, 2024
1 parent 8942111 commit 0aeb6df
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
6 changes: 4 additions & 2 deletions cmd/hooks/hooks.go
Original file line number Diff line number Diff line change
Expand Up @@ -524,11 +524,13 @@ func buildCliConfiguration(cmd *cobra.Command) (*config.Configuration, error) {
}

// CONVOY_ENABLE_FEATURE_FLAG
fflag, err := cmd.Flags().GetStringSlice("enable-feature-flag")
flags, err := cmd.Flags().GetStringSlice("enable-feature-flag")
if err != nil {
return nil, err
}
c.EnableFeatureFlag = fflag
if len(flags) > 0 {
c.EnableFeatureFlag = flags
}

// CONVOY_DISPATCHER_BLOCK_LIST
ipBlockList, err := cmd.Flags().GetStringSlice("ip-block-list")
Expand Down
1 change: 1 addition & 0 deletions worker/task/process_retry_event_delivery.go
Original file line number Diff line number Diff line change
Expand Up @@ -345,6 +345,7 @@ func parseAttemptFromResponse(m *datastore.EventDelivery, e *datastore.Endpoint,
ResponseHeader: *responseHeader,
RequestHeader: *requestHeader,
HttpResponseCode: resp.Status,
ResponseData: string(resp.Body),
Error: resp.Error,
Status: attemptStatus,

Expand Down

0 comments on commit 0aeb6df

Please sign in to comment.