-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation Improvements #476
Conversation
4959be9
to
36b13c7
Compare
@Kryptos-FR To address the comments from the other PR. I moved the pages to more clearly separate where the reference is and which pages go into depth (the learn section), I think it's good to have them separate. Even if it's a work in progress, it should be fine to move I believe. For the parameter tables, the only HTML I added is to add a Heres the table without being able to apply custom css to it, I think it's necessary to make it look reasonable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So far so good, I think it was needed to have enum descriptions.
CI failing though.
One thing to note is that I didn't implement attaching descriptions for rust enums, I think we can parse annotations in the decl macros but for now I left them empty from rust |
I see you commented on the other PR for things that are now split into this PR, but I'll comment over there (#472) |
Codecov Report
@@ Coverage Diff @@
## devel #476 +/- ##
=======================================
Coverage 81.24% 81.25%
=======================================
Files 218 219 +1
Lines 28789 28834 +45
=======================================
+ Hits 23389 23428 +39
- Misses 5400 5406 +6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Co-authored-by: ChelseaChX <[email protected]>
Co-authored-by: ChelseaChX <[email protected]>
# Conflicts: # .github/workflows/build-linux.yml
e090532
to
bb42398
Compare
7e249d6
to
960da23
Compare
Preview
As requested, split #472 into just the structure/technical changes, which are included here.