Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 4.3 #149

Merged
merged 5 commits into from
Jul 19, 2020
Merged

Release 4.3 #149

merged 5 commits into from
Jul 19, 2020

Conversation

edyoung
Copy link
Member

@edyoung edyoung commented Jul 11, 2020

Seems like it is about time for a 4.3 release.

The only thing I think is currently blocking is needing clearer instructions for how to install in a way that puts all the files in the right places. Please mention anything else you think should go in first.

Changelog:

  • Minimum Python version now 3.6
  • Supports .ASE gradient files
  • Improved manual
  • MacOS improvements
  • improved icons
  • much cleanup of python and C++ code
  • better testing infra via GitHub Actions
  • removed fractutils folder
  • improve install instructions

@edyoung edyoung linked an issue Jul 11, 2020 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2020

Codecov Report

Merging #149 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #149      +/-   ##
==========================================
+ Coverage   79.73%   79.76%   +0.02%     
==========================================
  Files          55       55              
  Lines       10920    10920              
==========================================
+ Hits         8707     8710       +3     
+ Misses       2213     2210       -3     
Impacted Files Coverage Δ
fract4d/options.py 91.35% <100.00%> (ø)
fract4d/fractal.py 90.57% <0.00%> (-0.15%) ⬇️
fract4d/gradient.py 90.94% <0.00%> (+0.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e191fc...8b1a43b. Read the comment docs.

@edyoung
Copy link
Member Author

edyoung commented Jul 19, 2020

@mindhells if you think the undefined behavior fixes are nearly ready I would like to wait for those. Otherwise I think we can release.

@mindhells
Copy link
Member

@mindhells if you think the undefined behavior fixes are nearly ready I would like to wait for those. Otherwise I think we can release.

I left a comment in #154. I think it's ok to merge but I will continue researching about the GIL, GTK and ref counting playing together.

@edyoung edyoung merged commit 5fb9f60 into master Jul 19, 2020
@delete-merged-branch delete-merged-branch bot deleted the release-4.3 branch July 19, 2020 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is fractutils folder really needed?
3 participants