-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimized builds/runs from IdeSession #181
Comments
Should I implement buffer timeout when running the exes? And/or separate buffer modes for stdout and stderr? I haven't investigated yet, but that will probably involve importing IdeBackendRTS into Main of the executable, etc. If so, I'd do that later on, as stage 2 of the implementation. Stage 1, with all other features (data dir, args, env, all RunActions operations), is ready, but not tested yet. But perhaps this is too intrusive for an executable and not needed as much? To make this consistent, I would also need to modify the generated .cabal file to build executables in this way, I suppose? |
While it would be nice, I think including the buffer timeout code would be too intrusive. Let's start off without it, and we'll start doing some testing. If user testing reveals that we really do need the timeout code, let's investigate again. |
The existing What we're currently missing is that second level: the ability to forcibly interrupt with a SIGTERM. |
Ignore this, I'm wrong. So I think this is all fine. |
A tested and fixed version is ready on branch runExe, ready to be merged. Here are the differences in behaviour compared to running snippets:
|
I'm a little concerned that exes aren't being tracked by the session state and automatically killed, but overall that might be a good situation for users, so let's wait until we have user testing to back up any change requests. Everything else makes perfect sense, thank you. Let me know when we should update to a newer ide-backend commit and start testing this. |
Merged to experimental and tested with ide-backend tests. |
Goal: in addition to the current
runStmt
API, we should be able to kick off an optimized build and manage its runtime with a similar API torunStmt
.The text was updated successfully, but these errors were encountered: