Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cpp: specify param type for double / double array parameters #921

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

cpp: specify param type for double / double array parameters #921

wants to merge 1 commit into from

Conversation

achim-k
Copy link
Collaborator

@achim-k achim-k commented Feb 17, 2025

Changelog

cpp: Add parameter type float64 & float64_array for floating point values

Docs

Description

From #519:

Some languages, such as JavaScript, do not differentiate between integers and floating point numbers. The float64 and float64_array types were added to avoid ambiguity by informing the client (or the server) that the value is a floating point number, or an array of it, respectively.

On the foxglove_bridge side this has been implemented in foxglove/ros-foxglove-bridge#256 but that change has apparently never found its way to this repo. This PR applies that change to this repo.

@achim-k achim-k requested a review from jtbandes February 17, 2025 15:31
@linear Linear
Copy link

linear bot commented Feb 17, 2025

FG-10507 ws-protocol cpp lib does not report double parameters with `"type": "float64"`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtbandes jtbandes jtbandes approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@achim-k @jtbandes