Update CompressedVideo format strings #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhurliman
approved these changes
Nov 23, 2024
snosenzo
approved these changes
Nov 26, 2024
| name: "format", | ||
| type: { type: "primitive", name: "string" }, | ||
| description: `Video format. | ||
| description: `Compressed video frame data. |
There was a problem hiding this comment.
Should we point here to the format field for more info on what this should look like?
There was a problem hiding this comment.
I figured since they are right next to each other maybe it’s fine? Could add it for redundancy though.
defunctzombie
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update CompressedVideo documentation for new formats, and describe format and data in more detail