Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI errors due to ubuntu 24.04 image rollout #1290

Merged
merged 4 commits into from
Dec 12, 2024
Merged

Fix CI errors due to ubuntu 24.04 image rollout #1290

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
97c4c71
use python 3.7 for CI
jtbandes Dec 12, 2024
58055ee
use 22.04 for swift
jtbandes Dec 12, 2024
390e270
use 3.8 instead
jtbandes Dec 12, 2024
39f7766
drive-by lint fix
jtbandes Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ jobs:
- run: yarn test:conformance --runner go-

conformance-python:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04 # required for python 3.8
steps:
- uses: actions/checkout@v4
with:
Expand All @@ -90,7 +90,7 @@ jobs:
cache: yarn
- uses: actions/setup-python@v5
with:
python-version: 3.7
python-version: 3.8
- run: cd python && pip install -e mcap
- run: yarn install --immutable
- run: yarn test:conformance:generate-inputs --verify
Expand Down Expand Up @@ -127,7 +127,7 @@ jobs:
- run: yarn test:conformance --runner ksy-

conformance-swift:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04 # https://github.com/swift-actions/setup-swift/issues/677
steps:
- uses: actions/checkout@v4
with:
Expand Down Expand Up @@ -200,7 +200,7 @@ jobs:
key: ${{ runner.os }}-${{ hashFiles('cpp/**/conanfile.py') }}
- uses: actions/setup-python@v5
with:
python-version: 3.7
python-version: 3.8
- run: pip install conan~=1.0
- run: bash build.sh --build-tests-only
- run: ./test/build/Debug/bin/unit-tests
Expand Down Expand Up @@ -293,7 +293,7 @@ jobs:
- run: yarn workspace @foxglove/mcap-example-text-annotation-demo typecheck

python:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04 # required for python 3.8
defaults:
run:
working-directory: python
Expand Down Expand Up @@ -464,7 +464,7 @@ jobs:
draft: false

swift:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04 # https://github.com/swift-actions/setup-swift/issues/677
steps:
- uses: actions/checkout@v4
with:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/website.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ jobs:
retention-days: 1

docs-python:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04 # required for python 3.8
steps:
- uses: actions/checkout@v4

Expand All @@ -71,7 +71,7 @@ jobs:
retention-days: 1

docs-swift:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04 # https://github.com/swift-actions/setup-swift/issues/677
steps:
- uses: actions/checkout@v4

Expand Down
1 change: 1 addition & 0 deletions website/src/components/McapRecordingDemo/McapRecordingDemo.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,6 +273,7 @@ export function McapRecordingDemo(): JSX.Element {
enableCamera,
recordH264,
recordH265,
recordVP9,
recordAV1,
recording,
videoStarted,
Expand Down
Loading