Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the record field name validator regex #151

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

pyrco
Copy link
Contributor

@pyrco pyrco commented Nov 8, 2024

The original regex allowed a literal "[]" at the end of a name, which breaks using the name as Python identifier.

The original regex allowed a literal "[]" at the end of a name, which
breaks using the name as Python identifier.
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.95%. Comparing base (c17dc6b) to head (c699a41).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #151      +/-   ##
==========================================
+ Coverage   83.92%   83.95%   +0.02%     
==========================================
  Files          34       34              
  Lines        3466     3466              
==========================================
+ Hits         2909     2910       +1     
+ Misses        557      556       -1     
Flag Coverage Δ
unittests 83.95% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pyrco pyrco merged commit 941f2cb into main Nov 11, 2024
18 of 20 checks passed
@pyrco pyrco deleted the fix-erroneous-field-name-validator branch November 11, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants