Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add targetd service flag to config #107

Merged
merged 4 commits into from
Nov 23, 2023

Conversation

cecinestpasunepipe
Copy link
Contributor

(DIS-2589)

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (dd51ce5) 43.93% compared to head (c1aee12) 44.44%.
Report is 1 commits behind head on main.

❗ Current head c1aee12 differs from pull request most recent head 4cd4b5e. Consider uploading reports for the commit 4cd4b5e to get more accurate results

Files Patch % Lines
acquire/log.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #107      +/-   ##
==========================================
+ Coverage   43.93%   44.44%   +0.50%     
==========================================
  Files          23       23              
  Lines        2854     2898      +44     
==========================================
+ Hits         1254     1288      +34     
- Misses       1600     1610      +10     
Flag Coverage Δ
unittests 44.44% <0.00%> (+0.50%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

acquire/acquire.py Outdated Show resolved Hide resolved
Miauwkeru
Miauwkeru previously approved these changes Nov 17, 2023
acquire/acquire.py Outdated Show resolved Hide resolved
@cecinestpasunepipe cecinestpasunepipe merged commit e879310 into main Nov 23, 2023
@cecinestpasunepipe cecinestpasunepipe deleted the DIS-2589_CTypes_Service_Targetd branch November 23, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants