New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FKVR-134: Link Titles #31

Open

patrickocoffeyo wants to merge 2 commits into master from feature/FKVR-134-link-labels

+56 −9

Contributor

patrickocoffeyo commented Aug 4, 2017 •

edited

Loading

FKVR-134

Steps to Test

Checkout this branch.
Run yarn or npm i in this repo's root.
Run npm run start in this repo's root.
Note that all links now have a title below them.

Note

How should these be styled? I made the text green like the modals, but I'm not sure if that's best.


          Add link titles to the link component and to all scene links

684ee99

Member

mirzu commented Aug 4, 2017

This is going to be part of the usability test, so it should be in the (B) Repo. . .


          Adjust link label so that it has a background plane.

0bf6ec1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet