Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#3156] Add setting to show attack roll result (AC check) card to players #3157

Merged
merged 3 commits into from
Jul 22, 2024

Conversation

pbasov
Copy link
Contributor

@pbasov pbasov commented Feb 29, 2024

module/settings.mjs Outdated Show resolved Hide resolved
@pbasov
Copy link
Contributor Author

pbasov commented Feb 29, 2024

@krbz999 Thanks for quick review (were hoping to grab a built minjs, but you don't build them for PRs).
Fixed the code, tested on my own instance, works as intended without reload, PTAL.

Player (left) side, GM side (right) False/True:
imageimage

Settings page:
image

Can be improved by an addional logic to hide/show precise AC number for players, but i think it's a separate commit.
Actually, let me figure out a way to hide AC, would make the feature complete.

@pbasov pbasov marked this pull request as draft February 29, 2024 14:49
@pbasov
Copy link
Contributor Author

pbasov commented Feb 29, 2024

GM and Player sides:
imageimage

Settings page:
image

@krbz999 please take a look

@pbasov pbasov marked this pull request as ready for review February 29, 2024 15:30
@pbasov pbasov requested a review from krbz999 February 29, 2024 15:50
@arbron arbron added feature request ux User experience related features or bugs labels Mar 2, 2024
module/settings.mjs Outdated Show resolved Hide resolved
lang/en.json Outdated Show resolved Hide resolved
lang/en.json Outdated Show resolved Hide resolved
module/settings.mjs Outdated Show resolved Hide resolved
module/documents/chat-message.mjs Outdated Show resolved Hide resolved
module/documents/chat-message.mjs Outdated Show resolved Hide resolved
module/documents/chat-message.mjs Outdated Show resolved Hide resolved
@arbron arbron added this to the D&D5E 3.2.0 milestone Mar 26, 2024
@arbron arbron changed the title Add setting to show attack roll result (AC check) card to players [#3156] Add setting to show attack roll result (AC check) card to players Mar 26, 2024
@arbron arbron changed the base branch from 3.1.x to 3.2.x April 4, 2024 19:58
@arbron arbron modified the milestones: D&D5E 3.2.0, D&D5E 3.3.0 May 20, 2024
@arbron arbron changed the base branch from 3.2.x to 3.3.x July 22, 2024 16:32
@Fyorl Fyorl merged commit b6ca06a into foundryvtt:3.3.x Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request ux User experience related features or bugs
Projects
None yet
4 participants