Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skill enrichers using name instead of ID of skills #2649

Closed
Ikaguia opened this issue Nov 25, 2023 · 0 comments
Closed

Skill enrichers using name instead of ID of skills #2649

Ikaguia opened this issue Nov 25, 2023 · 0 comments
Assignees
@Ikaguia
Labels
bug Functionality which is not working as intended
Milestone
D&D5E 2.4.1

Comments

@Ikaguia
Copy link
Contributor

Ikaguia commented Nov 25, 2023

On a fresh world with no modules, foundry v11, dnd5e 2.4.0:

If you create a skill check using the full name of a skill ([[/skill perception]]), that is the value stored in config.skill.
When that value is passed to actor.rollSkill, it gives an error, since it expects the ID, not the full name.
image
image
@Ikaguia Ikaguia mentioned this issue Nov 25, 2023
Merged
@arbron arbron added the bug Functionality which is not working as intended label Nov 27, 2023
@arbron arbron added this to the D&D5E 2.4.1 milestone Nov 27, 2023
Fyorl pushed a commit that referenced this issue Nov 28, 2023
@Ikaguia @arbron
[#2649] Fix enrichers using full key rather then short key when calli…
0067cff 
…ng roll method (#2650)

Co-authored-by: Jeff Hitchcock <[email protected]>
@Fyorl Fyorl closed this as completed Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ikaguia Ikaguia

Labels
bug Functionality which is not working as intended
Projects
None yet
Milestone
D&D5E 2.4.1
Development

No branches or pull requests
3 participants
@Fyorl @Ikaguia @arbron