Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advancement Type: Subclass #1407

Closed
arbron opened this issue Jan 16, 2022 · 2 comments · Fixed by #4072
Closed

Advancement Type: Subclass #1407

arbron opened this issue Jan 16, 2022 · 2 comments · Fixed by #4072

Comments

@arbron
Copy link
Collaborator

arbron commented Jan 16, 2022

This advancement allows the player to select their subclass at a certain level. This can only be added to "class" items and each class can only have a single advancement of this type. Much of this advancement would be the same as the Item Choice advancement (#1401) and could probably be an extension of that one.

This would resolve #1017.

Level Up Interface

The player would be presented with a list of available subclasses as well as have a drop area for adding an unlisted subclass. They can choose a single subclass before continuing.

The advancement would ensure that any item added is of a new subclass type created by #1080.

Configuration

This configuration object would contain a pool of item UUIDs and an option to disable the drop area.

{
  allowDrops: true,
  pool: ["Compendium.dnd5e.subclasses.MW1ExvBLm8Hg82aA"]
}

Value

The value object would contain the origin UUID of the subclass added and the ID of the object added to the actor.

{
  "EZsonMThTNLZq35j": "Compendium.dnd5e.subclasses.MW1ExvBLm8Hg82aA"
}

Future Directions

If a system for scanning compendiums for items of specific types is implemented, this could be used to automatically build a list of available subclasses that would be presented to the player.

@arbron
Copy link
Collaborator Author

arbron commented Jan 20, 2022

Originally in GitLab by @playest

What would you think if any feature could have a "trigger" when a certain level is reached in a certain class?
This way we could have:

  • classes proposing features when certain level are reached
  • features (the one proposed by the class or added by hand) proposing features

Which would give us the ability to have a tree of features that are giving other features to fill the character sheet with all the right value.

Obviously we would need a UI for all of that.

@arbron
Copy link
Collaborator Author

arbron commented Jan 21, 2022

That is basically what the new advancement system is.

@arbron arbron self-assigned this Jul 3, 2022
@arbron arbron modified the milestones: D&D5E 2.0.0, D&D5E 2.1.0 Jul 19, 2022
arbron added a commit to arbron/dnd5e that referenced this issue Aug 22, 2022
arbron added a commit to arbron/dnd5e that referenced this issue Aug 22, 2022
arbron added a commit to arbron/dnd5e that referenced this issue Aug 22, 2022
@arbron arbron added the blocked label Oct 5, 2022
arbron added a commit to arbron/dnd5e that referenced this issue Oct 19, 2022
arbron added a commit to arbron/dnd5e that referenced this issue Oct 19, 2022
arbron added a commit to arbron/dnd5e that referenced this issue Oct 19, 2022
@arbron arbron removed this from the D&D5E 2.1.0 milestone Dec 31, 2022
arbron added a commit that referenced this issue Aug 29, 2024
Introduces a new subclass advancement! This advancement doesn't do
anything on its own other than indicate the level at which the
class takes a subclass due to limitations in the advancement
system.

When a player reaches the level of the subclass advancement, their
features tab adds a "Add Subclass" button where the subclass icon
will eventually appear. Clicking this opens the compendium browser
with the subclass list locked to the current class's identifier.

While this doesn't fully implement what was originally desired
from the subclass advancement, this workflow should work pretty
well to fill in a major gap in the system's level-up workflow.

Closes #1017
Closes #1407
@arbron arbron added this to the D&D5E 4.0.0 milestone Aug 29, 2024
@arbron arbron closed this as completed in 6f51195 Aug 30, 2024
arbron added a commit that referenced this issue Aug 30, 2024
[#1407] Add Subclass advancement & selection interface on sheet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant