Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: override the eyre display handler globally #9766

Merged
merged 3 commits into from
Jan 27, 2025
Merged

feat: override the eyre display handler globally #9766

merged 3 commits into from
Jan 27, 2025

Conversation

DaniPopes
Copy link
Member

@DaniPopes DaniPopes commented Jan 27, 2025 •
edited
Loading

So that display_chain is used rather than the default which only displays the first error message.

@DaniPopes DaniPopes enabled auto-merge (squash) January 27, 2025 21:14
grandizzy
grandizzy approved these changes Jan 27, 2025
View reviewed changes
Copy link
Collaborator

@grandizzy grandizzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@DaniPopes DaniPopes merged commit 66e3648 into master Jan 27, 2025
22 checks passed
@DaniPopes DaniPopes deleted the dani/eyre-display-handler branch January 27, 2025 21:26
@grandizzy grandizzy added T-feature Type: feature C-forge Command: forge labels Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grandizzy grandizzy grandizzy approved these changes

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@yash-atreya yash-atreya Awaiting requested review from yash-atreya yash-atreya is a code owner

@zerosnacks zerosnacks Awaiting requested review from zerosnacks zerosnacks is a code owner

Assignees
No one assigned
Labels
C-forge Command: forge T-feature Type: feature
Projects
Foundry
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DaniPopes @grandizzy