Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: properly handle config load errors #9713

Merged
merged 3 commits into from
Jan 20, 2025
Merged

refactor: properly handle config load errors #9713

merged 3 commits into from
Jan 20, 2025

Conversation

DaniPopes
Copy link
Member

  • remove panicking methods
  • default to emitting warnings, with opt out
  • use LoadConfig trait where possible, removing From<&T> for Config

@DaniPopes DaniPopes marked this pull request as ready for review January 18, 2025 12:23
grandizzy
grandizzy approved these changes Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@grandizzy grandizzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

zerosnacks
zerosnacks approved these changes Jan 20, 2025
View reviewed changes
Copy link
Member

@zerosnacks zerosnacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@DaniPopes DaniPopes merged commit 3739859 into master Jan 20, 2025
22 checks passed
@DaniPopes DaniPopes deleted the dani/config-error-handling branch January 20, 2025 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zerosnacks zerosnacks zerosnacks approved these changes

@grandizzy grandizzy grandizzy approved these changes

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@yash-atreya yash-atreya Awaiting requested review from yash-atreya yash-atreya is a code owner

Assignees
No one assigned
Labels
None yet
Projects
Foundry
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DaniPopes @grandizzy @zerosnacks