fix(cheatcode): envOr use default for empty strings #9706
Conversation
grandizzy
requested review from
DaniPopes,
klkvr,
mattsse,
yash-atreya and
zerosnacks
as code owners
|
Ah I see, honestly I don't agree with this, the empty string is obviously a valid string value to have. If you don't want it to be set at all then you don't set it, commenting it in .env. |
Yeah, don't have a strong opinion, happy to close this PR and #7408 as working as designed if we're on the same page @yash-atreya @zerosnacks wdyt? |
| @@ -258,7 +258,10 @@ pub fn set_execution_context(context: ForgeContext) { | |||
| } | |||
|
|
|||
| fn env(key: &str, ty: &DynSolType) -> Result { | |||
| get_env(key).and_then(|val| string::parse(&val, ty).map_err(map_env_err(key, &val))) | |||
| get_env(key).and_then(|val| { | |||
| ensure!(!val.is_empty(), "env var value cannot be empty"); | |||
There was a problem hiding this comment.
an empty env var is valid.
I assume some users do this to erase the value, so some would treat "" as delete, but I think we shouldn't do this and force them to properly unset envvars instead?
|
Closing based on above. |
Motivation
closes #7408
vm.envOr(string)Solution