fix: error handling with retries when waiting for receipt

[grandizzy]

Motivation

closes #9636

Solution

• use Retry utility. add Continue variant to preserve number of retries (without decrementing)
• use Continue on watcher timeout err if tx is still known to the node (won't count as a retry). For all other errs use Retry
• tested with 100 txes on base sepolia

[grandizzy]

@klkvr do you think this makes sense in context of #9636 (comment) ?

[klkvr]

I don't think this will address the issue as we're hitting error in different arm #9636 (comment)

we could consider retrying several fatal errors instead of immidiately returning here

foundry/crates/script/src/receipts.rs

Lines 51 to 52 in b4a4733

	// treat other errors as fatal
	Err(e) => return Err(e.into()),

[grandizzy]

I don't think this will address the issue as we're hitting error in different arm #9636 (comment)

we could consider retrying several fatal errors instead of immidiately returning here

foundry/crates/script/src/receipts.rs

Lines 51 to 52 in b4a4733

	// treat other errors as fatal
	Err(e) => return Err(e.into()),

yeah, that's what I wanted with https://github.com/foundry-rs/foundry/pull/9650/files#diff-40b142bf1cc0e034c56533fad30c71161b2cc0b4dd4d6a72468e0649e3c7002dR61-R66 what do I miss? thank you!

[klkvr]

ah missed that second branch has changed too

lgtm but I'd keep provider.get_transaction_by_hash below so it runs for both cases

[grandizzy]

ah missed that second branch has changed too

lgtm but I'd keep provider.get_transaction_by_hash below so it runs for both cases

please recheck

[mattsse]

seems appropriate to retry this a few times