chore(config): use solar for inline config parsing
#9615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yash-atreya
requested review from
DaniPopes,
klkvr,
mattsse,
grandizzy and
zerosnacks
as code owners
DaniPopes
reviewed
Jan 2, 2025
DaniPopes
requested changes
Jan 3, 2025
DaniPopes
reviewed
Jan 3, 2025
crates/config/src/inline/natspec.rs
Outdated
| contract: contract_id.to_string(), | ||
| function: None, | ||
| line, | ||
| docs, |
There was a problem hiding this comment.
another thing is that line is documented and interpreted as {line}:{column}:{length}, but is in fact {byte_start}:{byte_end}:{source_id} in both parsers. This should be fixed in another PR
DaniPopes
approved these changes
Jan 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Ref: #9317
Solution
Replace
SolangParserwithSolarParser