chore: bump alloy #9496
Merged
chore: bump alloy #9496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
requested review from
DaniPopes,
klkvr,
grandizzy,
yash-atreya and
zerosnacks
as code owners
klkvr
reviewed
Dec 10, 2024
crates/cast/bin/cmd/wallet/mod.rs
Outdated
| @@ -533,6 +536,7 @@ flag to set your key via: | |||
| } | |||
|
|
|||
| /// Recovers an address from the specified message and signature | |||
| #[allow(deprecated)] | |||
There was a problem hiding this comment.
wouldn't it "just work" with PrimitiveSignature?
klkvr
approved these changes
Dec 10, 2024
|
it should yeah, let me do it right here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just wanted to make sure things are goodnoticed we were lacking one thing:alloy-rs/alloy#1758can be merged once publishedallowed legacy signature, but I believe could be migrated to newer one seperately