Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: force prevrandao on Moonbeam networks #9489

Merged
merged 5 commits into from
Dec 5, 2024
Merged

fix: force prevrandao on Moonbeam networks #9489

merged 5 commits into from
Dec 5, 2024

Conversation

mattsse
Copy link
Member

@mattsse mattsse commented Dec 4, 2024 •
edited by zerosnacks
Loading

Closes: #4232

  • Includes workaround for Moonbeam missing block.prevrandao
  • Adds regression test

@zerosnacks
Copy link
Member

Confirming this fix works correctly when ran against test in #4232 (comment)

Will push an additional test to this PR

@zerosnacks zerosnacks changed the title chore: force prevrandao fix: force prevrandao on Moonbeam networks Dec 5, 2024
@zerosnacks zerosnacks marked this pull request as ready for review December 5, 2024 09:45
grandizzy
grandizzy approved these changes Dec 5, 2024
View reviewed changes
Copy link
Collaborator

@grandizzy grandizzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@zerosnacks zerosnacks merged commit c161c7c into foundry-rs:master Dec 5, 2024
21 checks passed
@anajuliabit
Copy link

@zerosnacks could you create the release tag pls?

@zerosnacks
Copy link
Member

Hi @anajuliabit this will be included in tonight nightly, make sure to run foundryup tomorrow

@zerosnacks zerosnacks self-assigned this Dec 9, 2024
@grandizzy grandizzy added T-bug Type: bug C-forge Command: forge labels Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grandizzy grandizzy grandizzy approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

@yash-atreya yash-atreya Awaiting requested review from yash-atreya yash-atreya is a code owner

@zerosnacks zerosnacks Awaiting requested review from zerosnacks zerosnacks is a code owner

Assignees

@zerosnacks zerosnacks

Labels
C-forge Command: forge T-bug Type: bug
Projects
Foundry
Status: Completed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TX fails due to PrevrandaoNotSet on non-mainnet forks
4 participants
@mattsse @zerosnacks @anajuliabit @grandizzy