fix(forge): run dep.has_branch in correct dir
#9453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yash-atreya
requested review from
DaniPopes,
klkvr,
mattsse,
grandizzy and
zerosnacks
as code owners
yash-atreya
changed the title
forge): run git.has_branch in correct dir forge): run dep.has_branch in correct dir
grandizzy
reviewed
Dec 2, 2024
There was a problem hiding this comment.
Nice catch! This won't fix the installing from tag issue but we IMO we should merge the fix and then look to extend to tag / rev, @zerosnacks wdyt?
Yeah this doesn't address the tag/rev issue |
zerosnacks
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
Tested against the repro, works well!
Landing this fix already should unblock users, see https://github.com/OpenZeppelin/openzeppelin-contracts?tab=readme-ov-file#foundry-git
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #7225.
Current while installing a dep, we are checking for the deps branch in project root, which is incorrect as the tagged branch, if it exists, will be in the directory of the dep i.e
lib/dep-nameSolution
Check whether the branch exists in the correct dir i.e
lib/dep-nameTested this on @zerosnacks's repro https://github.com/zerosnacks/foundry-bug-7225-repro, correctly writes the
branch = 0.8in.gitmodules