fix(forge): detect invalid inline config keys
#9363
Conversation
yash-atreya
requested review from
DaniPopes,
klkvr,
mattsse,
grandizzy and
zerosnacks
as code owners
| return Err(InlineConfigError { | ||
| line, | ||
| source: InlineConfigParserError::InvalidConfigKey( | ||
| wrong_key, | ||
| format!("{VALID_CONFIG_KEYS:?}"), | ||
| ), | ||
| }); |
There was a problem hiding this comment.
I think a warning would be sufficient here given that the key is simply ignored when continuing
There was a problem hiding this comment.
Warnings won't be shown if --quiet is enabled.
Moreover, currently we error out on invalid property keys like fuzz.runssss. This keeps it consistent with that i.e err thrown on invalid keys.
| /// Used to detect invalid configuration keys in the inline config. | ||
| /// | ||
| /// # Example | ||
| /// | ||
| /// forge-config: default.fuzz.runs = 100 - `fuzz` is a valid key | ||
| /// forge-config: default.wrong.runs = 100 - `wrong` is an invalid key | ||
| const VALID_CONFIG_KEYS: [&str; 2] = ["fuzz", "invariant"]; |
There was a problem hiding this comment.
For now this is sufficient I think, assuming this functionality will be updated when we have full support for in-line configuration
| /// | ||
| /// forge-config: default.fuzz.runs = 100 - `fuzz` is a valid key | ||
| /// forge-config: default.wrong.runs = 100 - `wrong` is an invalid key | ||
| const VALID_CONFIG_KEYS: [&str; 2] = ["fuzz", "invariant"]; |
There was a problem hiding this comment.
I wonder if this isn't too simplistic?
There was a problem hiding this comment.
It is for now. But it won't be needed when we have full support for inline config.
|
@grandizzy can we merge this? |
|
Superseded by #9414 |
Motivation
Closes #5371
Solution
const VALID_CONFIG_KEYSVALID_CONFIG_KEYS.InvalidConfigKeyerror if it does.