Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "chore: update test values to cancun" #9358

Closed
wants to merge 1 commit into from
Closed

Revert "chore: update test values to cancun" #9358

wants to merge 1 commit into from

Conversation

Dargon789
Copy link

Reverts #9344

Dargon789
Dargon789 commented Nov 20, 2024
View reviewed changes
Copy link
Author

@Dargon789 Dargon789 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert "chore: update test values to cancun" #9358

@yash-atreya
Copy link
Member

@Dargon789 thanks for your PR. What is the motivation behind reverting #9344 ? The default evm version for foundry is now cancun. We need to updated the tests accordingly.

Closing this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@grandizzy grandizzy Awaiting requested review from grandizzy grandizzy is a code owner

@yash-atreya yash-atreya Awaiting requested review from yash-atreya yash-atreya is a code owner

@zerosnacks zerosnacks Awaiting requested review from zerosnacks zerosnacks is a code owner

Assignees
No one assigned
Labels
None yet
Projects
Foundry
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dargon789 @yash-atreya