feat(anvil): --cache-path
#9343
Conversation
yash-atreya
requested review from
DaniPopes,
klkvr,
mattsse,
grandizzy and
zerosnacks
as code owners
| .with_max_persisted_states(Some(10_usize)) | ||
| .with_blocktime(Some(Duration::from_millis(1))), | ||
| ) | ||
| .await; |
There was a problem hiding this comment.
is there a way to assert file was actually written in custom temp dir? I tried to manually test it but probably I am missing something as I wasn't able to get the json file dumped
There was a problem hiding this comment.
Yeah testing this is a bit hard. Wrote a better test here. 363010f
There was a problem hiding this comment.
thank you! yeah, managed to check file is generated with this test. I think that's good to have, drawback is that will slow down the CI (and potential flakiness), @zerosnacks wdyt?
If we are to keep it let's solve warnings here
https://github.com/foundry-rs/foundry/actions/runs/11933626813/job/33261072474#step:12:66
and maybe add one more assert to make sure the cache is actually populated
assert!(cache_path.read_dir().unwrap().next().is_some());
There was a problem hiding this comment.
looks good, only a comment re keeping the test or not @zerosnacks pls chime in
| .with_max_persisted_states(Some(10_usize)) | ||
| .with_blocktime(Some(Duration::from_millis(1))), | ||
| ) | ||
| .await; |
There was a problem hiding this comment.
thank you! yeah, managed to check file is generated with this test. I think that's good to have, drawback is that will slow down the CI (and potential flakiness), @zerosnacks wdyt?
If we are to keep it let's solve warnings here
https://github.com/foundry-rs/foundry/actions/runs/11933626813/job/33261072474#step:12:66
and maybe add one more assert to make sure the cache is actually populated
assert!(cache_path.read_dir().unwrap().next().is_some());
|
looks like the test is flaky, CI fails here https://github.com/foundry-rs/foundry/actions/runs/11948242152/job/33309461327#step:12:151 I propose to remove it, @zerosnacks @yash-atreya wdyt? |
* feat(`anvil`): --cache-path * nits * test * nit * run with tempdir * nit
Motivation
Closes #3512 + Closes #8654
Solution
Introduces the
--cache-pathflag to anvil letting users can configure where the old state is stored