feat(cast run): add --etherscan-api-key to resolve contract names
#9295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grandizzy
force-pushed
the
issue-3473
branch
from
dea7856 to
12bbe9e
Compare
grandizzy
requested review from
DaniPopes,
klkvr,
mattsse,
yash-atreya and
zerosnacks
as code owners
klkvr
reviewed
Nov 11, 2024
grandizzy
force-pushed
the
issue-3473
branch
from
efb33c9 to
09395da
Compare
grandizzy
force-pushed
the
issue-3473
branch
2 times, most recently
from
518e7f4 to
1696273
Compare
…sion Simplify test to avoid rate limiting.
grandizzy
force-pushed
the
issue-3473
branch
from
1696273 to
26ee3d7
Compare
grandizzy
changed the title
cast run): add --etherscan-api-key flag to resolve contract namescast run): add --etherscan-api-key to resolve contract names
klkvr
approved these changes
Nov 11, 2024
DaniPopes
approved these changes
Nov 11, 2024
rplusq
pushed a commit
to rplusq/foundry
that referenced
this pull request
Nov 29, 2024
foundry-rs#9295) * fix(cast run): decode traces for non mainnet * Add test * Changes after review: use EtherscanOpts, remove short -e from evm_version Simplify test to avoid rate limiting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #3473
Solution
get_remote_chain_id: do not assume mainnet chain ifmainnetin RPC URL (Alchemy hasopt-mainnet,arb-mainnetetc.)--etherscan-api-keyforcast run