Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chisel): on edit fail command only if execution failed #9155

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

grandizzy
Copy link
Collaborator

Motivation

Closes #4393

Solution

  • exit with command failed only on failures: show traces and failed are handled in same branch
    if new_session_source.config.traces || failed {

    and both results now in command failed as failed bool is not checked
    // If the contract execution failed, continue on without
    // updating the source.
    DispatchResult::CommandFailed(Self::make_error(
    "Failed to execute edited contract!",
    ))

@grandizzy grandizzy marked this pull request as ready for review October 22, 2024 06:15
@grandizzy grandizzy enabled auto-merge (squash) October 22, 2024 06:15
@grandizzy grandizzy merged commit 9fe891a into foundry-rs:master Oct 24, 2024
21 checks passed
rplusq pushed a commit to rplusq/foundry that referenced this pull request Nov 29, 2024
@grandizzy grandizzy added T-bug Type: bug C-chisel Command: chisel labels Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-chisel Command: chisel T-bug Type: bug
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

chisel !edit fails if !traces enabled
2 participants