feat(forge): add max supported EVM version in compiler -vv #9129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grandizzy
requested review from
DaniPopes,
klkvr,
mattsse,
yash-atreya and
zerosnacks
as code owners
zerosnacks
reviewed
Oct 16, 2024
zerosnacks
reviewed
Oct 16, 2024
zerosnacks
reviewed
Oct 16, 2024
DaniPopes
approved these changes
Oct 16, 2024
zerosnacks
approved these changes
Oct 16, 2024
please recheck 588bc53 as there are more things changes |
|
re-requesting review as there were some more changes re json output |
DaniPopes
approved these changes
Oct 16, 2024
…f non-verbose text mode
|
Pushed a documentation fix + a minor change to make the JSON not include paths when ran with verbosity mode 0 cc @grandizzy in line with When no verbosity flag is passed. Note the clearing of the paths happens after filtering as otherwise the version won't be reported correctly. |
zerosnacks
approved these changes
Oct 16, 2024
zerosnacks
changed the title
rplusq
pushed a commit
to rplusq/foundry
that referenced
this pull request
Nov 29, 2024
…s#9129) * feat(forge): add max supported EVM version in compiler -v * shorter message, displayed on -vv verbosity * match on verbosity * Respect verbosity in json, nicer json output * Redact default EVM version in tests * make --json output not output paths in verbosity mode 0, equivalent of non-verbose text mode --------- Co-authored-by: zerosnacks <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
closes #9125
forge compiler resolve -vSolution