-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(forge doc
): include custom natspec
#9075
feat(forge doc
): include custom natspec
#9075
Conversation
that's great, thanks! not a strong opinion but I think would be nicer to have bullet point for them (as
wdyt? |
Thanks! Supportive of changing the format, my suggestion would be to additionally add a header: Notes:
as in a list with a header stating |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @leovct!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!
okay i just now looked at the output for this one, looks good, but it is missing the label after ex. this
outputs this Notes:
instead of Notes:
|
It should be fixed! :) |
* feat(`forge doc`): include @Custom natspec * chore: make clippy happy * test: implement test for `is_custom` * chore: make rustfmt happy * doc: nit * chore: format custom tags
forge doc
): include @custom natspecforge doc
): include custom natspec
Motivation
Closes #8488
Include
@custom
natspec tags when rendering docs withforge doc
.Solution
I've chosen to prefix custom tags with
// Comment:
for visibility reasons, but I'm open to suggestions.Example with https://github.com/artgobblers/art-gobblers where I introduced some custom tags.