feat(cheatcodes): add delegatecall to pranking
#8863
Conversation
crates/cheatcodes/src/inspector.rs
Outdated
| @@ -833,6 +833,19 @@ impl Cheatcodes { | |||
|
|
|||
| // Apply our prank | |||
| if let Some(prank) = &self.prank { | |||
| // Apply delegate call. call.caller will not equal prank.prank_caller | |||
There was a problem hiding this comment.
Hey @zerosnacks, my understanding is a little fuzzy here. It seems in the case of a delegate call that call.caller == prank.prank_caller will not be true. Is it suitable to have this here? Ty.
There was a problem hiding this comment.
cc @DaniPopes would you have more context on this?
EdwardJES
force-pushed
the
edwardjes/delegatecall
branch
from
a7e8123 to
325c218
Compare
EdwardJES
force-pushed
the
edwardjes/delegatecall
branch
from
8a65994 to
d964aad
Compare
EdwardJES
changed the title
cheatcodes): add delegatecall to prankingcheatcodes): add delegatecall to pranking
|
Hi @EdwardJES thanks for your PR - my apologies that it has taken a while to respond |
EdwardJES
requested review from
DaniPopes,
klkvr,
mattsse,
grandizzy and
yash-atreya
as code owners
EdwardJES
changed the title
cheatcodes): add delegatecall to prankingcheatcodes): add delegatecall to pranking
|
gentle bump on this @zerosnacks, @DaniPopes . Thank you 🙏 |
|
@EdwardJES is there anything waiting from us to unblock the PR or can we start the review? thank you! |
|
@grandizzy all good to go, thanks! |
grandizzy
force-pushed
the
edwardjes/delegatecall
branch
from
bac569b to
3632509
Compare
|
@grandizzy, thank you for the review and help in rebasing. Added your suggestion 🙏. |
|
I tried to use this new feature but it doesn't work since I guess it requires an update of forge-std? Error (9582): Member "startPrank" not found or not visible after argument-dependent lookup in contract Vm.
--> test/EthernautCTF/DelegationExploit.t.sol:26:5:
|
26 | vm.startPrank(exploiter, true);
| ^^^^^^^^^^^^^
Error: Compilation failed |
|
indeed, will update and release a version with, thanks for flagging |
- add `delegatecall` flag to `prank` cheatcodes (foundry-rs/foundry#8863) - support EIP-7702 Delegations (`create/sign/attachDelegation`) (foundry-rs/foundry#9236) - add `contains` to check if a string contains another string (foundry-rs/foundry#9085)
* begin api and rough comments * impl cheatcode * add check for eoa * fix eoa check on each prank call * add to assets * prank compiling * delegate call working, storage not upating * delegate call working, some tidy up * add prank2 calls * impl remaining tests * formatting * forge fmt * add pranks to cheatcodes.json * run cargo cheats * If verbosity level is 1 or higher, it shows dirty files. * Fix, add EOA prank test * Revert "If verbosity level is 1 or higher, it shows dirty files." This reverts commit d03ac1d. * Fix test * apply on extdelegatecall --------- Co-authored-by: mgiagante <[email protected]> Co-authored-by: grandizzy <[email protected]>
|
Hi |
|
@varun-doshi yes it is, book is not updated yet |
Motivation
Closes #824. Currently there is no easy way to test delegate calls using foundry tests.
Solution
delegate_callflag to the prank.