Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: snapbox migration #8728

Merged
merged 50 commits into from
Aug 28, 2024
Merged
Changes from 1 commit
Commits
Show all changes
50 commits
Select commit Hold shift + click to select a range
1eac567
test basic flow
zerosnacks Aug 8, 2024
fcc447c
establish required test list by build errors
zerosnacks Aug 8, 2024
29083f5
experiment with abstractions
zerosnacks Aug 8, 2024
dfd7129
basic test with stderr
zerosnacks Aug 8, 2024
03f6e20
move over the stderr lossy tests
zerosnacks Aug 8, 2024
8724161
add `get_stdout_lossy` helper
zerosnacks Aug 8, 2024
093c59a
TestCommand will require a cleanup to route as much through Snapbox a…
zerosnacks Aug 8, 2024
12e933f
Merge branch 'master' into zerosnacks/snapbox-migration
zerosnacks Aug 22, 2024
a7f46c3
Merge branch 'master' into zerosnacks/snapbox-migration
zerosnacks Aug 23, 2024
51647a2
fix placeholder redacts
zerosnacks Aug 23, 2024
454f4bf
move tests
zerosnacks Aug 23, 2024
f3b4074
update tests
zerosnacks Aug 23, 2024
2208aff
fix tests
zerosnacks Aug 23, 2024
517d412
improve tests
zerosnacks Aug 23, 2024
d887bf4
continue
zerosnacks Aug 23, 2024
3546cc6
continue
zerosnacks Aug 23, 2024
364d081
clean up
zerosnacks Aug 23, 2024
8cc0df2
clean up
zerosnacks Aug 23, 2024
f19cf03
match against "Updating dependencies in"
zerosnacks Aug 26, 2024
ca32536
fix broken tests, make sure to clear consistently to force recompilat…
zerosnacks Aug 26, 2024
7bc0a8a
port more tests
zerosnacks Aug 26, 2024
b9e6206
additional tests
zerosnacks Aug 26, 2024
0d76da1
more tests
zerosnacks Aug 26, 2024
417e2a5
clean up
zerosnacks Aug 26, 2024
6d50901
avoid unnecessary fuse
zerosnacks Aug 26, 2024
641ef3a
fix malformed test + full output comparison asserting specific layout…
zerosnacks Aug 26, 2024
9d3dce2
access list ordering is not consistent
zerosnacks Aug 26, 2024
3741cf6
enforce block layout
zerosnacks Aug 26, 2024
18ede7b
use stdout_eq file with relative path as dynamic joined CARGO_MANIFES…
zerosnacks Aug 26, 2024
e050f18
continue migrating tests
zerosnacks Aug 26, 2024
d51e33a
more tests
zerosnacks Aug 26, 2024
bdede9b
more tests
zerosnacks Aug 26, 2024
fadbda3
improve tests
zerosnacks Aug 26, 2024
4fb9e0e
restore test
zerosnacks Aug 26, 2024
758d440
replace stdout_lossy, unify access
zerosnacks Aug 26, 2024
cac4eef
replace more lossy stdout tests
zerosnacks Aug 27, 2024
feedee9
continue porting tests
zerosnacks Aug 27, 2024
12cec9f
more tests
zerosnacks Aug 27, 2024
ac8390f
clean up
zerosnacks Aug 27, 2024
e6efa68
use redactions for scripts, enforce stricter regex
zerosnacks Aug 27, 2024
73d8b88
start porting more tests using undesired helpers
zerosnacks Aug 27, 2024
26f8514
remove assert_non_empty_stdout helper, enforce stdout layouts
zerosnacks Aug 27, 2024
3671909
use snapbox inside of helpers
zerosnacks Aug 27, 2024
360646f
replace cmd.execute
zerosnacks Aug 27, 2024
290fc74
fix CI tests
zerosnacks Aug 27, 2024
5e16192
soldeer has inconsistent spelling for some reason
zerosnacks Aug 27, 2024
b4c3dc6
Merge branch 'master' into zerosnacks/snapbox-migration
zerosnacks Aug 27, 2024
0bb60c6
attempt fix flaky test
zerosnacks Aug 27, 2024
88bc479
no idea why soldeer is so spotty
zerosnacks Aug 27, 2024
a187734
make tests more robust, redact "Compiling N files" with [COMPILING_FI…
zerosnacks Aug 28, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
soldeer has inconsistent spelling for some reason
zerosnacks committed Aug 27, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit 5e161921eea3997240a4a6e6733be4b7e7cc0bbd
14 changes: 7 additions & 7 deletions crates/forge/tests/cli/soldeer.rs
Original file line number Diff line number Diff line change
@@ -15,7 +15,7 @@ forgesoldeer!(install_dependency, |prj, cmd| {
let foundry_file = prj.root().join("foundry.toml");

cmd.arg("soldeer").args([command, dependency]).assert_success().stdout_eq(str![[r#"
🦌 Running soldeer install 🦌
🦌 Running [..]oldeer install 🦌
...
"#]]);

@@ -61,7 +61,7 @@ forgesoldeer!(install_dependency_git, |prj, cmd| {
let foundry_file = prj.root().join("foundry.toml");

cmd.arg("soldeer").args([command, dependency, git]).assert_success().stdout_eq(str![[r#"
🦌 Running soldeer install 🦌
🦌 Running [..]oldeer install 🦌
...
"#]]);

@@ -111,7 +111,7 @@ forgesoldeer!(install_dependency_git_commit, |prj, cmd| {
.args([command, dependency, git, rev_flag, commit])
.assert_success()
.stdout_eq(str![[r#"
🦌 Running soldeer install 🦌
🦌 Running [..]oldeer install 🦌
...
"#]]);

@@ -166,7 +166,7 @@ forge-std = { version = "1.8.1" }
}

cmd.arg("soldeer").arg(command).assert_success().stdout_eq(str![[r#"
🦌 Running soldeer update 🦌
🦌 Running [..]oldeer update 🦌
...

"#]]);
@@ -223,7 +223,7 @@ forge-std = "1.8.1"
}

cmd.arg("soldeer").arg(command).assert_success().stdout_eq(str![[r#"
🦌 Running soldeer update 🦌
🦌 Running [..]oldeer update 🦌
...

"#]]);
@@ -270,11 +270,11 @@ forgesoldeer!(login, |prj, cmd| {
.assert_failure()
.stderr_eq(str![[r#"
Error:
Failed to run soldeer Invalid email
Failed to run [..]oldeer Invalid email

"#]])
.stdout_eq(str![[r#"
🦌 Running soldeer login 🦌
🦌 Running [..]oldeer login 🦌

ℹ️ If you do not have an account, please go to soldeer.xyz to create one.
📧 Please enter your email: