Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: coverage bug #7532

Merged
merged 1 commit into from
Apr 1, 2024
Merged

fix: coverage bug #7532

merged 1 commit into from
Apr 1, 2024

Conversation

klkvr
Copy link
Member

@klkvr klkvr commented Apr 1, 2024

Motivation

Ref #7510 (comment)

#7510 introduced bug which resulted in broken coverage reports for projects with multiple solc versions used.

We were collecting coverage items separately for each version, however, anchors search was done for each artifact, thus we were always overriding anchors data for all artifacts with data from last seen version.

@onbjerg onbjerg added the T-bug Type: bug label Apr 1, 2024
@klkvr klkvr merged commit f625d0f into foundry-rs:master Apr 1, 2024
19 checks passed
Copy link

@Elgayar777 Elgayar777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-bug Type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants