chore: small cheatcode improvements #4799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
commented
Apr 22, 2023
Comment on lines
+21
to
+23
| struct Log { bytes32[] topics; bytes data; } | ||
| struct Rpc { string name; string url; } | ||
| struct FsMetadata { bool isDir; bool isSymlink; uint256 length; bool readOnly; uint256 modified; uint256 accessed; uint256 created; } |
There was a problem hiding this comment.
I tried formatting the structs to more lines but it doesn't seem like they get parsed? @mattsse
There was a problem hiding this comment.
yeah looks like the struct parser of abigen has limitations when it comes to new lines, I think it uses \n as separator
iFrostizz
pushed a commit
to iFrostizz/foundry
that referenced
this pull request
Apr 22, 2023
* fmt: abigens * Pass by reference when patching Hardhat selector rebase master
mattsse
added a commit
that referenced
this pull request
Apr 26, 2023
* add conditional breakpoints * help desk * char return * chore: small cheatcode improvements (#4799) * fmt: abigens * Pass by reference when patching Hardhat selector rebase master * help desk * fmt * help desk rebase * chore(clippy): make clippy happy --------- Co-authored-by: DaniPopes <[email protected]> Co-authored-by: Matthias Seitz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Review with "Hide whitespace" on
Solution