fix(forge): Change depth check for expect revert #3820
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As discussed elsewhere, we are going to continue to support same depth expectRevert+revert patterns, so closing this |
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix #3437
Solution
I believe there should be no need to ever check
<=for expect revert instead of==, because the only scenario in which it is possible for<=to be occur is for a same depth revert which isn't supported (i.e. we explicitly specify it is based on the next call, and by having<=, it could be such that its actually this call which is in-congruent with the documentation and desired functionality).This may be a breaking change for some tests, but technically is correct (I believe) and will highlight a broken test.