Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[draft] Optimism support #306

Closed
wants to merge 5 commits into from
Closed

[draft] Optimism support #306

wants to merge 5 commits into from

Conversation

pyk
Copy link
Contributor

@pyk pyk commented Dec 25, 2021

Add Optimism verification support for foundry.

This PR is in progress, wait for new Official ethers is released with Optimism support.

gakonst/ethers-rs#737

TODO (pyk): Add example contract here verified using foundry

@pyk
Copy link
Contributor Author

pyk commented Dec 25, 2021

Btw I tried to deploy & verify the simple contract to optimism but got the following error:

Screen Shot 2021-12-25 at 16 14 31

Not sure what cause the error tho, coz the gas fee estimator on Optimism Kovan is working fine.

here is the command that I use:


forge create src/Foundry.sol:Foundry --private-key <PK> --rpc-url https://kovan.optimism.io

@pyk
Copy link
Contributor Author

pyk commented Dec 26, 2021

Update: Successfully deploy contract to Optimism Kovan, but blocked by #311 when verifying.

https://kovan-optimistic.etherscan.io/address/0x51421a04483f4006ceeb66cb2c917f9699ef7419

@gakonst
Copy link
Member

gakonst commented Dec 26, 2021

Doing a cargo update -p ethers will pull in the PR from ethers.

I think that always enabling the legacy feature is not the best way forward here, the "right" way to do it is to check the network type and call .legacy() on the .deploy() call, i.e. factory.legacy().send()

@pyk
Copy link
Contributor Author

pyk commented Dec 27, 2021

I will close this and open new PR

@pyk pyk closed this Dec 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants