-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug "fix": temporarily disable docker build on release version #1313
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you
@mattsse I now remember - this is why I was against libgit2, because it re-introduced OpenSSL.. |
oh I think we can disable the ssh feature which should get rid of openssl by default |
That would at least solve the first issue, and hopefully the alpine Opened this PR as a stop-gap to avoid GHA failures until we can take a closer look. Didn't want to be causing all those ❌. The prior images from before the org migration still work for those using them. Alpine cuts our docker image size by more than half (last time I checked), but sadly comes with little bugs like this that would likely just "work" on other distros. |
let's give a try at removing openssl again, and if doesnt solve we can merge this |
Confirmed resolved in my fork with #1316. Can someone kick off either a release or Docker Build job in the org repo? |
Just triggered! |
Success! I think the last thing needed is to set the package to public at the org level (github defaults to private). |
Should be public now 😄 |
Motivation
Docker build is currently failing.
After 64087b59c0ac9abb4b5e04d8c84e8bab47f4c6c3, the docker build has been failing at compiling
group v0.11.0
due to missing openssl-dependency. Adding this dependency solves that issue, but reveals another problem with compilingfoundry-cli
:Example job with openssl fixed but foundry-cli failing here.
This is definitely some alpine library related issue.
Solution
Temporarily disable the docker build so that releases do not fail. Restore once fixed (should be able to take a look in a few days).
Bug opened here: #1314