Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug "fix": temporarily disable docker build on release version #1313

Closed
wants to merge 4 commits into from

Conversation

dmfxyz
Copy link
Contributor

@dmfxyz dmfxyz commented Apr 14, 2022

Motivation

Docker build is currently failing.

After 64087b59c0ac9abb4b5e04d8c84e8bab47f4c6c3, the docker build has been failing at compiling group v0.11.0 due to missing openssl-dependency. Adding this dependency solves that issue, but reveals another problem with compiling foundry-cli:

#13 808.6    Compiling foundry-cli v0.2.0 (/opt/foundry/cli)
#13 809.7 error: failed to run custom build command for `foundry-cli v0.2.0 (/opt/foundry/cli)`
#13 809.7 
#13 809.7 Caused by:
#13 809.7   process didn't exit successfully: `/opt/foundry/target/release/build/foundry-cli-f3551be4cc3b0164/build-script-build` (signal: 11, SIGSEGV: invalid memory reference)
#13 809.7 warning: build failed, waiting for other jobs to finish...

Example job with openssl fixed but foundry-cli failing here.
This is definitely some alpine library related issue.

Solution

Temporarily disable the docker build so that releases do not fail. Restore once fixed (should be able to take a look in a few days).
Bug opened here: #1314

@dmfxyz dmfxyz mentioned this pull request Apr 14, 2022
2 tasks
@dmfxyz
Copy link
Contributor Author

dmfxyz commented Apr 14, 2022

@gakonst @onbjerg @mattsse FYI

Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@gakonst
Copy link
Member

gakonst commented Apr 15, 2022

@mattsse I now remember - this is why I was against libgit2, because it re-introduced OpenSSL..

rust-lang/git2-rs#623

@mattsse
Copy link
Member

mattsse commented Apr 15, 2022

oh I think we can disable the ssh feature which should get rid of openssl by default

@dmfxyz
Copy link
Contributor Author

dmfxyz commented Apr 15, 2022

That would at least solve the first issue, and hopefully the alpine foundry-cli compilation failure.

Opened this PR as a stop-gap to avoid GHA failures until we can take a closer look. Didn't want to be causing all those ❌. The prior images from before the org migration still work for those using them.

Alpine cuts our docker image size by more than half (last time I checked), but sadly comes with little bugs like this that would likely just "work" on other distros.

@gakonst
Copy link
Member

gakonst commented Apr 15, 2022

let's give a try at removing openssl again, and if doesnt solve we can merge this

@onbjerg onbjerg added the T-bug Type: bug label Apr 15, 2022
@dmfxyz
Copy link
Contributor Author

dmfxyz commented Apr 15, 2022

Disabling libgit2 ssh appears to have worked! Will do some testing with the new image and then close this PR. Thanks @mattsse

@dmfxyz
Copy link
Contributor Author

dmfxyz commented Apr 15, 2022

Confirmed resolved in my fork with #1316. Can someone kick off either a release or Docker Build job in the org repo?

@gakonst
Copy link
Member

gakonst commented Apr 15, 2022

Just triggered!

@dmfxyz
Copy link
Contributor Author

dmfxyz commented Apr 15, 2022

Just triggered!

Success! I think the last thing needed is to set the package to public at the org level (github defaults to private).

@onbjerg
Copy link
Member

onbjerg commented Apr 16, 2022

Should be public now 😄

@gakonst gakonst closed this Apr 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-bug Type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants